Fix crashes when loading gles2.cc on browser startup, and during playback.

content/common/gpu/gpu_channel.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #if defined(OS_WIN)
 #include <windows.h>
 #endif
 
 #include "content/common/gpu/gpu_channel.h"
 
@@ skipping 194 matching lines @@
     IPC_MESSAGE_HANDLER(GpuChannelMsg_CreateVideoDecoder,
         OnCreateVideoDecoder)
     IPC_MESSAGE_HANDLER(GpuChannelMsg_DestroyVideoDecoder,
         OnDestroyVideoDecoder)
     IPC_MESSAGE_HANDLER(GpuChannelMsg_CreateTransportTexture,
         OnCreateTransportTexture)
     IPC_MESSAGE_HANDLER(GpuChannelMsg_AssignTexturesToVideoDecoder,
         OnAssignTexturesToVideoDecoder)
     IPC_MESSAGE_UNHANDLED(handled = false)
   IPC_END_MESSAGE_MAP()
-  DCHECK(handled);
+  DCHECK(handled) << msg.type();
   return handled;
 }
 
 int GpuChannel::GenerateRouteID() {
   static int last_id = 0;
   return ++last_id;
 }
 
 void GpuChannel::OnInitialize(base::ProcessHandle renderer_process) {
   // Initialize should only happen once.
@@ skipping 92 matching lines @@
     return;
   }
 
   GpuCommandBufferStub* stub = stubs_.Lookup(command_buffer_route_id);
   // TODO(vrk): Need to notify renderer that given route is invalid.
   if (!stub)
     return;
 
   int32 decoder_id = GenerateRouteID();
 
+  // TODO(fischman): this is a BUG.  We hand off stub->scheduler()->decoder()
+  // to be baked into the resulting GpuVideoDecodeAccelerator, but we don't own
+  // that GVDA, and we make no attempt to tear it down if/when
+  // stub->scheduler()->decoder() is destroyed.  GpuVideoService should be
+  // subsumed into this class and GpuVideoDecodeAccelerator should be owned by
+  // the GpuCommandBufferStub that owns the commandbuffer GVDA is using.
   bool ret = service->CreateVideoDecoder(
       this, &router_, decoder_host_id, decoder_id, stub->scheduler()->decoder(),
       configs);
   DCHECK(ret) << "Failed to create a GpuVideoDecodeAccelerator";
 }
 
 void GpuChannel::OnDestroyVideoDecoder(int32 decoder_id) {
 #if defined(ENABLE_GPU)
   LOG(ERROR) << "GpuChannel::OnDestroyVideoDecoder";
   GpuVideoService* service = GpuVideoService::GetInstance();
@@ skipping 55 matching lines @@
 
 #if defined(OS_POSIX)
 int GpuChannel::GetRendererFileDescriptor() {
   int fd = -1;
   if (channel_.get()) {
     fd = channel_->GetClientFileDescriptor();
   }
   return fd;
 }
 #endif  // defined(OS_POSIX)