Issue 7196002: Fix checkbox in windows uninstaller.

Issue 7196002: Fix checkbox in windows uninstaller. (Closed)

Created:
9 years, 6 months ago by Roger Tawa OOO till Jul 10th

Modified:
9 years, 5 months ago

Reviewers:
commit-bot: I haz the power, Ben Goodger (Google)

CC:
chromium-reviews, dhollowa

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Fix checkbox in windows uninstaller. BUG=84791 TEST=Test the checkbox in the uninstaller as mentioned in the bug, but also all checkboxes in chrome too. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=90640

Patch Set 1 #

Patch Set 2 : Fix build break on non-windows builds #

Patch Set 3 : Remove testing hack #

Patch Set 4 : Add missing include file #

Patch Set 5 : Fix trybot break in chromeos #

Total comments: 4

Patch Set 6 : Addressing review comments #

Patch Set 7 : Uploading after sync merge #

Created: 9 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+77 lines, -16 lines)			Patch
M	ui/gfx/native_theme_win.h	View	1 2 3 4 5 6	1 chunk	+2 lines, -1 line	0 comments	Download
M	ui/gfx/native_theme_win.cc	View	1 2 3 4 5 6	4 chunks	+60 lines, -8 lines	0 comments	Download
M	views/controls/button/checkbox.cc	View	1 2 3 4 5 6	1 chunk	+0 lines, -1 line	0 comments	Download
M	views/controls/button/text_button.cc	View	1 2 3 4 5 6	3 chunks	+7 lines, -5 lines	0 comments	Download
M	views/examples/native_theme_button_example.cc	View	1 2 3 4 5 6	1 chunk	+8 lines, -1 line	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

Roger Tawa OOO till Jul 10th

Hi Ben, please take another look. Thanks.

9 years, 6 months ago (2011-06-22 20:10:31 UTC) #2

Ben Goodger (Google)

http://codereview.chromium.org/7196002/diff/18001/views/controls/button/checkbox.cc File views/controls/button/checkbox.cc (right): http://codereview.chromium.org/7196002/diff/18001/views/controls/button/checkbox.cc#newcode305 views/controls/button/checkbox.cc:305: params->button.classic_state |= checked_ ? DFCS_CHECKED: 0; Can't this be ...

9 years, 6 months ago (2011-06-23 17:31:34 UTC) #3

Roger Tawa OOO till Jul 10th

Thanks Ben, comments addressed and changes uploaded. Code is cleaner this way too. http://codereview.chromium.org/7196002/diff/18001/views/controls/button/checkbox.cc File ...

9 years, 6 months ago (2011-06-23 19:22:11 UTC) #4

Change committed as 90640

Expand Messages | Collapse Messages