Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Unified Diff: ui/gfx/native_theme_win.cc

Issue 7196002: Fix checkbox in windows uninstaller. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Uploading after sync merge Created 9 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/gfx/native_theme_win.h ('k') | views/controls/button/checkbox.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/gfx/native_theme_win.cc
===================================================================
--- ui/gfx/native_theme_win.cc (revision 90572)
+++ ui/gfx/native_theme_win.cc (working copy)
@@ -126,7 +126,26 @@
NULL, TS_TRUE, &size);
ReleaseDC(NULL, hdc);
- return SUCCEEDED(hr) ? Size(size.cx, size.cy) : Size();
+ if (FAILED(hr)) {
+ // TODO(rogerta): For now, we need to support radio buttons and checkboxes
+ // when theming is not enabled. Support for other parts can be added
+ // if/when needed.
+ switch (part) {
+ case kCheckbox:
+ case kRadio:
+ // TODO(rogerta): I was not able to find any API to get the default
+ // size of these controls, so determined these values empirically.
+ size.cx = 13;
+ size.cy = 13;
+ break;
+ default:
+ size.cx = 0;
+ size.cy = 0;
+ break;
+ }
+ }
+
+ return Size(size.cx, size.cy);
}
void NativeThemeWin::PaintToNonPlatformCanvas(SkCanvas* canvas,
@@ -497,8 +516,7 @@
}
RECT rect_win = rect.ToRECT();
- return PaintButton(hdc, BP_PUSHBUTTON, state_id, extra.classic_state,
- &rect_win);
+ return PaintButton(hdc, state, extra, BP_PUSHBUTTON, state_id, &rect_win);
}
HRESULT NativeThemeWin::PaintRadioButton(HDC hdc,
@@ -526,8 +544,7 @@
}
RECT rect_win = rect.ToRECT();
- return PaintButton(hdc, BP_RADIOBUTTON, state_id, extra.classic_state,
- &rect_win);
+ return PaintButton(hdc, state, extra, BP_RADIOBUTTON, state_id, &rect_win);
}
HRESULT NativeThemeWin::PaintCheckbox(HDC hdc,
@@ -563,19 +580,54 @@
}
RECT rect_win = rect.ToRECT();
- return PaintButton(hdc, BP_CHECKBOX, state_id, extra.classic_state,
- &rect_win);
+ return PaintButton(hdc, state, extra, BP_CHECKBOX, state_id, &rect_win);
}
HRESULT NativeThemeWin::PaintButton(HDC hdc,
+ State state,
+ const ButtonExtraParams& extra,
int part_id,
int state_id,
- int classic_state,
RECT* rect) const {
HANDLE handle = GetThemeHandle(BUTTON);
if (handle && draw_theme_)
return draw_theme_(handle, hdc, part_id, state_id, rect, NULL);
+ // Adjust classic_state based on part, state, and extras.
+ int classic_state = extra.classic_state;
+ switch(part_id) {
+ case BP_CHECKBOX:
+ classic_state |= DFCS_BUTTONCHECK;
+ break;
+ case BP_RADIOBUTTON:
+ classic_state |= DFCS_BUTTONRADIO;
+ break;
+ case BP_PUSHBUTTON:
+ classic_state |= DFCS_BUTTONPUSH;
+ break;
+ default:
+ NOTREACHED() << "Unknown part_id: " << part_id;
+ break;
+ }
+
+ switch(state) {
+ case kDisabled:
+ classic_state |= DFCS_INACTIVE;
+ break;
+ case kPressed:
+ classic_state |= DFCS_PUSHED;
+ break;
+ case kNormal:
+ case kHovered:
+ break;
+ default:
+ NOTREACHED() << "Unknown state: " << state;
+ break;
+ }
+
+ if (extra.checked)
+ classic_state |= DFCS_CHECKED;
+
// Draw it manually.
// All pressed states have both low bits set, and no other states do.
const bool focused = ((state_id & ETS_FOCUSED) == ETS_FOCUSED);
« no previous file with comments | « ui/gfx/native_theme_win.h ('k') | views/controls/button/checkbox.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698