Move UI specific implementation from ProfileSyncService to SyncSetupFlowHandler.

chrome/browser/sync/sync_setup_wizard.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/sync/sync_setup_wizard.h"
 
 #include <stddef.h>
 #include <ostream>
 
 #include "base/logging.h"
@@ skipping 65 matching lines @@
 bool SyncSetupWizard::IsVisible() const {
   return flow_container_->get_flow() != NULL;
 }
 
 void SyncSetupWizard::Focus() {
   SyncSetupFlow* flow = flow_container_->get_flow();
   if (flow)
     flow->Focus();
 }
 
+void SyncSetupWizard::ShowSyncSetup(State state) {
+  SyncSetupFlow* flow = flow_container_->get_flow();
+  if (flow) {
+    flow->Focus();
+    return;

[Andrew T Wilson (Slow), 2011/07/11 18:12:51]

Don't we still need to Step in the case that there's already a flow object?

[qsr (NOT THE RIGHT qsr), 2011/07/12 07:01:37]

If you look at what was done in ProfileSyncService, there was not step done if
the wizard was visible. Mainly, the ShowSyncSetup must only be called to start a
new flow, otherwise it will just focus the UI.

+  }
+  Step(state);
+  flow = flow_container_->get_flow();
+  if (flow)
+    flow->ShowSyncSetup();

[tim (not reviewing), 2011/07/11 14:44:25]

I think I see what changed that caused my confusion last week... Flow::Run did
indeed used to "show" the UI, but it was removed ~6 weeks ago by
http://codereview.chromium.org/7057038.  But the method is still named Run,
which is really confusing to me.  

Could we not have Run(...) call flow_handler-> ShowSyncSetup, akin to how it
worked before that CR above, and then not need this new method?

+}
+
 SyncSetupFlow* SyncSetupWizard::AttachSyncSetupHandler(
     SyncSetupFlowHandler* handler) {
   SyncSetupFlow* flow = flow_container_->get_flow();
   if (!flow || !flow->AttachSyncSetupHandler(handler))
     return NULL;
 
   return flow;
 }