Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(146)

Issue 7192006: Fix wrong parenthesis in stub ARM and MIPS generation code. (Closed)

Created:
9 years, 6 months ago by fschneider
Modified:
9 years, 6 months ago
CC:
v8-dev
Visibility:
Public.

Description

Fix wrong parenthesis in stub ARM and MIPS generation code. I think the problem did not manifest as a bug, since the only consequence was to generate extra code to return heap number results in case of the INT32-stub. Committed: http://code.google.com/p/v8/source/detail?r=8321

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+62 lines, -64 lines) Patch
M src/arm/code-stubs-arm.cc View 2 chunks +31 lines, -32 lines 0 comments Download
M src/mips/code-stubs-mips.cc View 2 chunks +31 lines, -32 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
fschneider
9 years, 6 months ago (2011-06-16 12:09:20 UTC) #1
Søren Thygesen Gjesse
9 years, 6 months ago (2011-06-17 07:05:27 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698