Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1692)

Unified Diff: chrome/browser/download/download_util.cc

Issue 7189076: Localize strings, speeds. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: typo Created 9 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/download/download_util.cc
diff --git a/chrome/browser/download/download_util.cc b/chrome/browser/download/download_util.cc
index 58cfef5553b630d948102bd0b6f968e06df137ed..d0b234b0f839cf470cab41a97e81b992e3ecbf9d 100644
--- a/chrome/browser/download/download_util.cc
+++ b/chrome/browser/download/download_util.cc
@@ -54,6 +54,7 @@
#include "third_party/skia/include/core/SkShader.h"
#include "ui/base/l10n/l10n_util.h"
#include "ui/base/resource/resource_bundle.h"
+#include "ui/base/text/bytes_formatting.h"
#include "ui/gfx/canvas_skia.h"
#include "ui/gfx/image/image.h"
#include "ui/gfx/rect.h"
@@ -764,8 +765,7 @@ DictionaryValue* CreateDownloadItemValue(DownloadItem* download, int id) {
string16 GetProgressStatusText(DownloadItem* download) {
int64 total = download->total_bytes();
int64 size = download->received_bytes();
- DataUnits amount_units = GetByteDisplayUnits(size);
- string16 received_size = FormatBytes(size, amount_units, true);
+ string16 received_size = ui::FormatBytes(size, ui::DATA_UNITS_NATURAL, true);
string16 amount = received_size;
// Adjust both strings for the locale direction since we don't yet know which
@@ -773,8 +773,7 @@ string16 GetProgressStatusText(DownloadItem* download) {
base::i18n::AdjustStringForLocaleDirection(&amount);
if (total) {
- amount_units = GetByteDisplayUnits(total);
- string16 total_text = FormatBytes(total, amount_units, true);
+ string16 total_text = ui::FormatBytes(total, ui::DATA_UNITS_NATURAL, true);
base::i18n::AdjustStringForLocaleDirection(&total_text);
base::i18n::AdjustStringForLocaleDirection(&received_size);
@@ -785,8 +784,9 @@ string16 GetProgressStatusText(DownloadItem* download) {
amount.assign(received_size);
}
int64 current_speed = download->CurrentSpeed();
- amount_units = GetByteDisplayUnits(current_speed);
- string16 speed_text = FormatSpeed(current_speed, amount_units, true);
+ string16 speed_text = ui::FormatSpeed(current_speed,
+ ui::DATA_UNITS_NATURAL,
+ true);
base::i18n::AdjustStringForLocaleDirection(&speed_text);
base::TimeDelta remaining;

Powered by Google App Engine
This is Rietveld 408576698