Make o.o.p. proxy handle PPP_Instance versions 0.4 and 0.5.

Make o.o.p. proxy handle PPP_Instance versions 0.4 and 0.5.

Move & tweak PPP_Instance_Combined to ppapi_shared so the proxy can use it.  Use versioned PPP_Instance types only.

BUG=82606
TEST=run tests o.o.p.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=90984

[dmichael (off chromium), 2011-06-17 22:31:05]

brettw primary, ddorwin FYI

[dmichael (off chromium), 2011-06-18 00:43:11]

I missed the unit tests when changing things, and the shuttle wifi is failing me
right now.  You can hold off on reviewing til I fix this CL.

The scripting turn off will probably be ~1 week from Monday to account for this
and NaCl test porting.

[brettw, 2011-06-24 00:35:24]

LGTM

http://codereview.chromium.org/7189045/diff/16050/ppapi/proxy/host_dispatcher.h
File ppapi/proxy/host_dispatcher.h (right):

http://codereview.chromium.org/7189045/diff/16050/ppapi/proxy/host_dispatcher...
ppapi/proxy/host_dispatcher.h:120: std::map<std::string, PluginIFSupport>
plugin_if_support_;
I guess I would have just done:
std::map<std::string, boo> plugin_if_supported_
and avoided the enum. It would also clean up the insert code. You can do it this
way if you think it's better, though.

[dmichael (off chromium), 2011-06-28 22:53:10]

Okay, I finally have a test up and running.  I refactored the proxy test stuff
to support 'TwoWayTests', which set up basic IPC for you so you can test both
sides of a Proxy.

I haven't added ppapi_unittests anywhere yet; it's still not being run.  How do
I add a unittest?

[dmichael(do not use this one), 2011-06-29 00:17:36]

Looks like I forgot an include that's breaking my windows try...  I also
forgot to roll in your comment from the previous look.  I'll clean it up
first thing in the morning, but the new test stuff probably won't change
much if you want to start looking.
On Jun 28, 2011 4:53 PM, <dmichael@chromium.org> wrote:
> Okay, I finally have a test up and running. I refactored the proxy test
> stuff
> to support 'TwoWayTests', which set up basic IPC for you so you can test
> both
> sides of a Proxy.
>
> I haven't added ppapi_unittests anywhere yet; it's still not being run.
> How do
> I add a unittest?
>
> http://codereview.chromium.org/7189045/

[dmichael (off chromium), 2011-06-29 16:13:57]

Okay, I think this one's ready to go.  Sorry this has taken so long; since you
LGTMed patch set 4, you can probably just focus on the testing stuff in patches
5-7.

Thanks!

http://codereview.chromium.org/7189045/diff/16050/ppapi/proxy/host_dispatcher.h
File ppapi/proxy/host_dispatcher.h (right):

http://codereview.chromium.org/7189045/diff/16050/ppapi/proxy/host_dispatcher...
ppapi/proxy/host_dispatcher.h:120: std::map<std::string, PluginIFSupport>
plugin_if_support_;
Good suggestion.  Done.

[brettw, 2011-06-29 17:11:29]

LGTM, testing stuff looks sweet.

http://codereview.chromium.org/7189045/diff/23004/ppapi/proxy/plugin_dispatch...
File ppapi/proxy/plugin_dispatcher.cc (right):

http://codereview.chromium.org/7189045/diff/23004/ppapi/proxy/plugin_dispatch...
ppapi/proxy/plugin_dispatcher.cc:134: if (msg.routing_id() <= 0 ||
msg.routing_id() >= INTERFACE_ID_COUNT) {
Whoops!