Make o.o.p. proxy handle PPP_Instance versions 0.4 and 0.5.

ppapi/proxy/host_dispatcher.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef PPAPI_PROXY_HOST_DISPATCHER_H_
 #define PPAPI_PROXY_HOST_DISPATCHER_H_
 
 #include <map>
 #include <string>
 #include <vector>
@@ skipping 92 matching lines @@
 
  private:
   friend class HostDispatcherTest;
 
   // Makes an instance of the given PPB interface proxy, storing it in the
   // target_proxies_ array. An proxy for this interface must not exist yet.
   InterfaceProxy* CreatePPBInterfaceProxy(const InterfaceProxy::Info* info);
 
   PP_Module pp_module_;
 
-  enum PluginInterfaceSupport {
-    INTERFACE_UNQUERIED = 0,  // Must be 0 so memset(0) will clear the list.
+  enum PluginIFSupport {
     INTERFACE_SUPPORTED,
     INTERFACE_UNSUPPORTED
   };
-  PluginInterfaceSupport plugin_interface_support_[INTERFACE_ID_COUNT];
+  typedef std::map<std::string, PluginIFSupport> PluginIFSupportMap;
+  // Maps interface name to whether that interface is supported. If an interface
+  // name is not in the map, that implies that we haven't queried for it yet.
+  std::map<std::string, PluginIFSupport> plugin_if_support_;

[brettw, 2011/06/24 00:35:24]

I guess I would have just done:
std::map<std::string, boo> plugin_if_supported_
and avoided the enum. It would also clean up the insert code. You can do it this
way if you think it's better, though.

[dmichael (off chromium), 2011/06/29 16:13:57]

Good suggestion.  Done.

 
   // All target proxies currently created. These are ones that receive
   // messages. They are created on demand when we receive messages.
   scoped_ptr<InterfaceProxy> target_proxies_[INTERFACE_ID_COUNT];
 
   // Function proxies created for "new-style" FunctionGroups.
   // TODO(brettw) this is in progress. It should be merged with the target
   // proxies so there is one list to consult.
   scoped_ptr< ::ppapi::FunctionGroupBase >
       function_proxies_[INTERFACE_ID_COUNT];
@@ skipping 25 matching lines @@
  private:
   HostDispatcher* dispatcher_;
 
   DISALLOW_COPY_AND_ASSIGN(ScopedModuleReference);
 };
 
 }  // namespace proxy
 }  // namespace pp
 
 #endif  // PPAPI_PROXY_HOST_DISPATCHER_H_