Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(254)

Issue 7172018: Revert 89178 - Create a browser feature extractor that runs after the renderer has (Closed)

Created:
9 years, 6 months ago by noelutz
Modified:
9 years, 6 months ago
Reviewers:
noelutz
CC:
chromium-reviews, Paweł Hajdan Jr.
Visibility:
Public.

Description

Revert 89178 - Create a browser feature extractor that runs after the renderer has decided that a page is phishing according to the extracted features in the renderer. For now we don't use these features in the classification. We only use them on the server side. Currently, the browser feature extractor extracts a bunch of features based on the history service (e.g., has the user seen this URL before). BUG=None TEST=BrowserFeatureExtractorTest Review URL: http://codereview.chromium.org/7119003 TBR=noelutz@google.com Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=89205

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -681 lines) Patch
D chrome/browser/safe_browsing/browser_feature_extractor.h View 1 chunk +0 lines, -161 lines 0 comments Download
D chrome/browser/safe_browsing/browser_feature_extractor.cc View 1 chunk +0 lines, -296 lines 0 comments Download
D chrome/browser/safe_browsing/browser_feature_extractor_unittest.cc View 1 chunk +0 lines, -163 lines 0 comments Download
M chrome/browser/safe_browsing/client_side_detection_host.h View 3 chunks +1 line, -9 lines 0 comments Download
M chrome/browser/safe_browsing/client_side_detection_host.cc View 4 chunks +6 lines, -24 lines 0 comments Download
M chrome/browser/safe_browsing/client_side_detection_host_unittest.cc View 8 chunks +7 lines, -19 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/safe_browsing/csd.proto View 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
noelutz
9 years, 6 months ago (2011-06-15 17:17:46 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698