Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3079)

Unified Diff: chrome/browser/safe_browsing/client_side_detection_host.h

Issue 7172018: Revert 89178 - Create a browser feature extractor that runs after the renderer has (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 9 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/safe_browsing/client_side_detection_host.h
===================================================================
--- chrome/browser/safe_browsing/client_side_detection_host.h (revision 89204)
+++ chrome/browser/safe_browsing/client_side_detection_host.h (working copy)
@@ -17,8 +17,7 @@
class TabContents;
namespace safe_browsing {
-class BrowserFeatureExtractor;
-class ClientPhishingRequest;
+
class ClientSideDetectionService;
// This class is used to receive the IPC from the renderer which
@@ -58,11 +57,6 @@
// Otherwise, we do nothing. Called in UI thread.
void MaybeShowPhishingWarning(GURL phishing_url, bool is_phishing);
- // Callback that is called when the browser feature extractor is done.
- // This method is responsible for deleting the request object. Called on
- // the UI thread.
- void FeatureExtractionDone(bool success, ClientPhishingRequest* request);
-
// Used for testing. This function does not take ownership of the service
// class.
void set_client_side_detection_service(ClientSideDetectionService* service);
@@ -78,8 +72,6 @@
// Keep a handle to the latest classification request so that we can cancel
// it if necessary.
scoped_refptr<ShouldClassifyUrlRequest> classification_request_;
- // Browser-side feature extractor.
- scoped_ptr<BrowserFeatureExtractor> feature_extractor_;
base::ScopedCallbackFactory<ClientSideDetectionHost> cb_factory_;

Powered by Google App Engine
This is Rietveld 408576698