Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(293)

Issue 7171025: Fix flicker on tab switch on chromeos. (Closed)

Created:
9 years, 6 months ago by davemoore (google)
Modified:
9 years, 5 months ago
Reviewers:
DaveMoore, sky
CC:
chromium-reviews, dhollowa
Visibility:
Public.

Description

Fix flicker on tab switch on chromeos. BUG=84721 TEST=Switch tabs...no flicker Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=91710

Patch Set 1 #

Patch Set 2 : Simplify usage of native view #

Patch Set 3 : Fixed test regressions #

Patch Set 4 : Removed accidental mod of apps_page.js #

Patch Set 5 : Null out host_widget_ after removing it #

Total comments: 4

Patch Set 6 : more comments for review #

Patch Set 7 : Remove all children instead of stashing last one #

Unified diffs Side-by-side diffs Delta from patch set Stats (+67 lines, -48 lines) Patch
M views/controls/native/native_view_host_gtk.h View 1 2 3 4 5 6 1 chunk +3 lines, -0 lines 0 comments Download
M views/controls/native/native_view_host_gtk.cc View 1 2 3 4 5 6 9 chunks +64 lines, -48 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
davemoore (google)
9 years, 6 months ago (2011-06-15 21:04:55 UTC) #1
DaveMoore
9 years, 5 months ago (2011-07-01 19:31:09 UTC) #2
sky
http://codereview.chromium.org/7171025/diff/9001/views/controls/native/native_view_host_gtk.cc File views/controls/native/native_view_host_gtk.cc (right): http://codereview.chromium.org/7171025/diff/9001/views/controls/native/native_view_host_gtk.cc#newcode108 views/controls/native/native_view_host_gtk.cc:108: gtk_container_remove(GTK_CONTAINER(fixed_), host_widget_); Does this mean the host_widget_ is leaked ...
9 years, 5 months ago (2011-07-01 20:00:38 UTC) #3
DaveMoore
http://codereview.chromium.org/7171025/diff/9001/views/controls/native/native_view_host_gtk.cc File views/controls/native/native_view_host_gtk.cc (right): http://codereview.chromium.org/7171025/diff/9001/views/controls/native/native_view_host_gtk.cc#newcode108 views/controls/native/native_view_host_gtk.cc:108: gtk_container_remove(GTK_CONTAINER(fixed_), host_widget_); If we don't remove it here it ...
9 years, 5 months ago (2011-07-01 20:13:34 UTC) #4
davemoore (google)
I changed the approach. Instead of keeping a pointer to the last host_widget I remove ...
9 years, 5 months ago (2011-07-06 22:47:46 UTC) #5
sky
9 years, 5 months ago (2011-07-06 23:03:39 UTC) #6
Nice. LGTM

Powered by Google App Engine
This is Rietveld 408576698