Fix flicker on tab switch on chromeos.

Fix flicker on tab switch on chromeos.

BUG=84721
TEST=Switch tabs...no flicker

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=91710

[sky, 2011-07-01 20:00:38]

http://codereview.chromium.org/7171025/diff/9001/views/controls/native/native...
File views/controls/native/native_view_host_gtk.cc (right):

http://codereview.chromium.org/7171025/diff/9001/views/controls/native/native...
views/controls/native/native_view_host_gtk.cc:108:
gtk_container_remove(GTK_CONTAINER(fixed_), host_widget_);
Does this mean the host_widget_ is leaked if someone else doesn't delete it?
Also, add a comment here.

http://codereview.chromium.org/7171025/diff/9001/views/controls/native/native...
File views/controls/native/native_view_host_gtk.h (right):

http://codereview.chromium.org/7171025/diff/9001/views/controls/native/native...
views/controls/native/native_view_host_gtk.h:90: GtkWidget* host_widget_;
How come you need to cache this? If it's because of lifetime, can you update the
comment.

[DaveMoore, 2011-07-01 20:13:34]

http://codereview.chromium.org/7171025/diff/9001/views/controls/native/native...
File views/controls/native/native_view_host_gtk.cc (right):

http://codereview.chromium.org/7171025/diff/9001/views/controls/native/native...
views/controls/native/native_view_host_gtk.cc:108:
gtk_container_remove(GTK_CONTAINER(fixed_), host_widget_);
If we don't remove it here it will get destroyed when fixed_ is destroyed and
we'll crash later when someone tries to use / delete it, as happens in some (not
all cases).
On 2011/07/01 20:00:38, sky wrote:
> Does this mean the host_widget_ is leaked if someone else doesn't delete it?
> Also, add a comment here.

http://codereview.chromium.org/7171025/diff/9001/views/controls/native/native...
File views/controls/native/native_view_host_gtk.h (right):

http://codereview.chromium.org/7171025/diff/9001/views/controls/native/native...
views/controls/native/native_view_host_gtk.h:90: GtkWidget* host_widget_;
This is cached because by the time of the destructor (when we have to delete it)
the host_ has NULLed it out in some (not all) cases.
On 2011/07/01 20:00:38, sky wrote:
> How come you need to cache this? If it's because of lifetime, can you update
the
> comment.

[davemoore (google), 2011-07-06 22:47:46]

I changed the approach. Instead of keeping a pointer to the last host_widget I
remove all children of fixed_ before destroying it. This also lets me remove the
ref and unref calls, as the widget remains a child of fixed_ throughout.

[sky, 2011-07-06 23:03:39]

Nice. LGTM