Fix flicker on tab switch on chromeos.

views/controls/native/native_view_host_gtk.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "views/controls/native/native_view_host_gtk.h"
 
 #include <gtk/gtk.h>
 #include <algorithm>
 
 #include "base/logging.h"
@@ skipping 77 matching lines @@
 }  // namespace
 
 ////////////////////////////////////////////////////////////////////////////////
 // NativeViewHostGtk, public:
 
 NativeViewHostGtk::NativeViewHostGtk(NativeViewHost* host)
     : host_(host),
       installed_clip_(false),
       destroy_signal_id_(0),
       focus_signal_id_(0),
-      fixed_(NULL) {
+      fixed_(NULL),
+      host_widget_(NULL) {
   CreateFixed(false);
 }
 
 NativeViewHostGtk::~NativeViewHostGtk() {
-  if (fixed_)
+  if (fixed_) {
+    if (host_widget_ &&
+        GTK_IS_WIDGET(host_widget_) &&
+        gtk_widget_get_parent(host_widget_) == fixed_)
+      gtk_container_remove(GTK_CONTAINER(fixed_), host_widget_);

[sky, 2011/07/01 20:00:38]

Does this mean the host_widget_ is leaked if someone else doesn't delete it?
Also, add a comment here.

[DaveMoore, 2011/07/01 20:13:34]

If we don't remove it here it will get destroyed when fixed_ is destroyed and
we'll crash later when someone tries to use / delete it, as happens in some (not
all cases).
On 2011/07/01 20:00:38, sky wrote:

     gtk_widget_destroy(fixed_);
+  }
 }
 
 ////////////////////////////////////////////////////////////////////////////////
 // NativeViewHostGtk, NativeViewHostWrapper implementation:
 
 void NativeViewHostGtk::NativeViewAttached() {
-  DCHECK(host_->native_view());
-  if (gtk_widget_get_parent(host_->native_view()))
-    gtk_widget_reparent(host_->native_view(), fixed_);
-  else
-    gtk_container_add(GTK_CONTAINER(fixed_), host_->native_view());
+  host_widget_ = host_->native_view();
+  DCHECK(host_widget_);
+
+  GtkWidget* host_parent = gtk_widget_get_parent(host_widget_);
+  if (host_parent) {
+    if (host_parent != fixed_)
+      gtk_widget_reparent(host_widget_, fixed_);
+  } else {
+    gtk_container_add(GTK_CONTAINER(fixed_), host_widget_);
+  }
+
+  // We need to clear the background so we don't get flicker on tab switching.
+  // To do that we must realize the widget if it's not already.
+  if (!GTK_WIDGET_REALIZED(host_widget_))
+    gtk_widget_realize(host_widget_);
+  gdk_window_set_back_pixmap(host_widget_->window, NULL, false);
 
   // Let the widget know that the native component has been painted.
-  views::NativeWidgetGtk::RegisterChildExposeHandler(host_->native_view());
+  views::NativeWidgetGtk::RegisterChildExposeHandler(host_widget_);
 
   if (!destroy_signal_id_) {
-    destroy_signal_id_ = g_signal_connect(host_->native_view(),
+    destroy_signal_id_ = g_signal_connect(host_widget_,
                                           "destroy", G_CALLBACK(CallDestroy),
                                           this);
   }
 
   if (!focus_signal_id_) {
-    focus_signal_id_ = g_signal_connect(host_->native_view(),
+    focus_signal_id_ = g_signal_connect(host_widget_,
                                         "focus-in-event",
                                         G_CALLBACK(CallFocusIn), this);
   }
 
   // Always layout though.
   host_->Layout();
 
   // We own the native view as long as it's attached, so that we can safely
   // reparent it in multiple passes.
-  gtk_widget_ref(host_->native_view());
+  gtk_widget_ref(host_widget_);
 
   // TODO(port): figure out focus.
 }
 
 void NativeViewHostGtk::NativeViewDetaching(bool destroyed) {
-  DCHECK(host_->native_view());
+  DCHECK(host_widget_);
 
-  g_signal_handler_disconnect(G_OBJECT(host_->native_view()),
-                              destroy_signal_id_);
+  g_signal_handler_disconnect(G_OBJECT(host_widget_), destroy_signal_id_);
   destroy_signal_id_ = 0;
 
-  g_signal_handler_disconnect(G_OBJECT(host_->native_view()),
-                              focus_signal_id_);
+  g_signal_handler_disconnect(G_OBJECT(host_widget_), focus_signal_id_);
   focus_signal_id_ = 0;
 
   installed_clip_ = false;
 
-  if (fixed_ && !destroyed) {
-    DCHECK_NE(static_cast<gfx::NativeView>(NULL),
-              gtk_widget_get_parent(host_->native_view()));
-    gtk_container_remove(GTK_CONTAINER(fixed_), host_->native_view());
-    DCHECK_EQ(
-        0U, g_list_length(gtk_container_get_children(GTK_CONTAINER(fixed_))));
-  }
-
-  g_object_unref(G_OBJECT(host_->native_view()));
+  g_object_unref(G_OBJECT(host_widget_));
 }
 
 void NativeViewHostGtk::AddedToWidget() {
   if (!fixed_)
     CreateFixed(false);
   if (gtk_widget_get_parent(fixed_))
     GetHostWidget()->ReparentChild(fixed_);
   else
     GetHostWidget()->AddChild(fixed_);
 
   if (!host_->native_view())
     return;
 
-  if (gtk_widget_get_parent(host_->native_view()))
-    gtk_widget_reparent(host_->native_view(), fixed_);
+  host_widget_ = host_->native_view();
+  if (gtk_widget_get_parent(host_widget_))
+    gtk_widget_reparent(host_widget_, fixed_);
   else
-    gtk_container_add(GTK_CONTAINER(fixed_), host_->native_view());
+    gtk_container_add(GTK_CONTAINER(fixed_), host_widget_);
 
-  if (host_->IsVisibleInRootView())
+  if (host_->IsVisibleInRootView()) {
+    gtk_widget_show(host_widget_);
     gtk_widget_show(fixed_);
-  else
+  } else {
     gtk_widget_hide(fixed_);
+  }
   host_->Layout();
 }
 
 void NativeViewHostGtk::RemovedFromWidget() {
   if (!host_->native_view())
     return;
   DestroyFixed();
 }
 
 void NativeViewHostGtk::InstallClip(int x, int y, int w, int h) {
@@ skipping 36 matching lines @@
     fixed_x += -child_x;
     fixed_y += -child_y;
     fixed_w = std::min(installed_clip_bounds_.width(), w);
     fixed_h = std::min(installed_clip_bounds_.height(), h);
   }
 
   // Don't call gtk_widget_size_allocate now, as we're possibly in the
   // middle of a re-size, and it kicks off another re-size, and you
   // get flashing.  Instead, we'll set the desired size as properties
   // on the widget and queue the re-size.
-  gtk_views_fixed_set_widget_size(host_->native_view(), child_w, child_h);
-  gtk_fixed_move(GTK_FIXED(fixed_), host_->native_view(), child_x, child_y);
+  gtk_views_fixed_set_widget_size(host_widget_, child_w, child_h);
+  gtk_fixed_move(GTK_FIXED(fixed_), host_widget_, child_x, child_y);
 
   // Size and place the fixed_.
   GetHostWidget()->PositionChild(fixed_, fixed_x, fixed_y, fixed_w, fixed_h);
 
+  gtk_widget_show(host_widget_);
   gtk_widget_show(fixed_);
-  gtk_widget_show(host_->native_view());
 }
 
 void NativeViewHostGtk::HideWidget() {
   if (fixed_)
     gtk_widget_hide(fixed_);
 }
 
 void NativeViewHostGtk::SetFocus() {
-  DCHECK(host_->native_view());
-  gtk_widget_grab_focus(host_->native_view());
+  DCHECK(host_widget_);
+  gtk_widget_grab_focus(host_widget_);
 }
 
 gfx::NativeViewAccessible NativeViewHostGtk::GetNativeViewAccessible() {
   return NULL;
 }
 
 ////////////////////////////////////////////////////////////////////////////////
 // NativeViewHostGtk, private:
 
 void NativeViewHostGtk::CreateFixed(bool needs_window) {
@@ skipping 13 matching lines @@
     // restore focus after we create the new fixed_. This way focus hasn't
     // really moved.
     gtk_widget_grab_focus(GetHostWidget()->GetNativeView());
   }
 
   DestroyFixed();
 
   fixed_ = gtk_views_fixed_new();
   gtk_widget_set_name(fixed_, "views-native-view-host-fixed");
   gtk_fixed_set_has_window(GTK_FIXED(fixed_), needs_window);
+
   // Defeat refcounting. We need to own the fixed.
   gtk_widget_ref(fixed_);
 
   NativeWidgetGtk* widget_gtk = GetHostWidget();
-  if (widget_gtk)
+  if (widget_gtk) {
     widget_gtk->AddChild(fixed_);
+    // Clear the background so we don't get flicker.
+    gtk_widget_realize(fixed_);
+    gdk_window_set_back_pixmap(fixed_->window, NULL, false);
+  }
 
-  if (host_->native_view())
-    gtk_container_add(GTK_CONTAINER(fixed_), host_->native_view());
+  if (host_->native_view()) {
+    host_widget_ = host_->native_view();
+    gtk_container_add(GTK_CONTAINER(fixed_), host_widget_);
+  }
 
-  if (widget_gtk && host_->native_view() && focused_widget) {
+  if (widget_gtk && host_widget_ && focused_widget)
     gtk_widget_grab_focus(focused_widget);
-  }
+
   if (focus_event_blocked) {
     // Unblocking a signal handler that is not blocked fails.
     // Unblock only when it's unblocked.
     UnblockFocusSignals(GetHostWidget()->GetNativeView(), NULL);
   }
 }
 
 void NativeViewHostGtk::DestroyFixed() {
   if (!fixed_)
     return;
 
   gtk_widget_hide(fixed_);
+  if (host_widget_) {
+    // We can safely remove the widget from its container since we own the
+    // widget from the moment it is attached.
+    gtk_container_remove(GTK_CONTAINER(fixed_), host_widget_);
+    host_widget_ = NULL;
+  }
   GetHostWidget()->RemoveChild(fixed_);
 
-  if (host_->native_view()) {
-    // We can safely remove the widget from its container since we own the
-    // widget from the moment it is attached.
-    gtk_container_remove(GTK_CONTAINER(fixed_), host_->native_view());
-  }
   // fixed_ should not have any children this point.
   DCHECK_EQ(0U,
             g_list_length(gtk_container_get_children(GTK_CONTAINER(fixed_))));
   gtk_widget_destroy(fixed_);
   fixed_ = NULL;
 }
 
 NativeWidgetGtk* NativeViewHostGtk::GetHostWidget() const {
   return static_cast<NativeWidgetGtk*>(host_->GetWidget()->native_widget());
 }
@@ skipping 43 matching lines @@
 // static
 NativeViewHostWrapper* NativeViewHostWrapper::CreateWrapper(
     NativeViewHost* host) {
   if (Widget::IsPureViews() &&
       views::ViewsDelegate::views_delegate->GetDefaultParentView())
     return new NativeViewHostViews(host);
   return new NativeViewHostGtk(host);
 }
 
 }  // namespace views