Add script to package hwqual release from buildbot artifacts.

Add script to package hwqual release from buildbot artifacts.

[petkov, 2010-03-09 07:28:43]

http://codereview.chromium.org/716001/diff/1/2
File src/scripts/archive_hwqual.sh (right):

http://codereview.chromium.org/716001/diff/1/2#newcode17
src/scripts/archive_hwqual.sh:17: DEFINE_string output_tag "chromeos-hwqual"
"Name used in tar"
The TAG in the name should really be ${BOARD}-${VERSION}. I'm not sure where
either of these values come from...

http://codereview.chromium.org/716001/diff/1/2#newcode53
src/scripts/archive_hwqual.sh:53: mv rootfs_test.image
"o/${FLAGS_output_tag}/chromeos-hwqual-usb.img"
Hmm, that's probably not a simple mv. You need to invoke image_to_usb.sh to with
a file output, I think.

http://codereview.chromium.org/716001/diff/1/2#newcode60
src/scripts/archive_hwqual.sh:60: tar cjf
"${FLAGS_from}/${FLAGS_output_tag}.tar.bz2" .
I'm not sure what the context of running this script is but you end up with a
tarball in a temp directory. It doesn't seems like whoever invokes this script
knows the complete path to the tarball.

[Raja Aluri, 2010-03-09 20:59:14]

I have had some issues tar -j before, may be it's better to spell --bzip2 out.
Raja

http://codereview.chromium.org/716001/diff/1/2
File src/scripts/archive_hwqual.sh (right):

http://codereview.chromium.org/716001/diff/1/2#newcode60
src/scripts/archive_hwqual.sh:60: tar cjf
"${FLAGS_from}/${FLAGS_output_tag}.tar.bz2" .
-j, --bzip2
              filter archive through bzip2, use to decompress .bz2 files.  
WARNING:  some previous versions of tar used option -I to filter through bzip2. 
When writing scripts, use --bzip2 instead of -j so that both older and newer tar
versions will work.

[kmixter1, 2010-03-11 00:08:49]

http://codereview.chromium.org/716001/diff/1/2
File src/scripts/archive_hwqual.sh (right):

http://codereview.chromium.org/716001/diff/1/2#newcode17
src/scripts/archive_hwqual.sh:17: DEFINE_string output_tag "chromeos-hwqual"
"Name used in tar"
On 2010/03/09 07:28:43, petkov wrote:
> The TAG in the name should really be ${BOARD}-${VERSION}. I'm not sure where
> either of these values come from...

A calling script should be setting output_tag to this.

http://codereview.chromium.org/716001/diff/1/2#newcode53
src/scripts/archive_hwqual.sh:53: mv rootfs_test.image
"o/${FLAGS_output_tag}/chromeos-hwqual-usb.img"
On 2010/03/09 07:28:43, petkov wrote:
> Hmm, that's probably not a simple mv. You need to invoke image_to_usb.sh to
with
> a file output, I think.

Done.

http://codereview.chromium.org/716001/diff/1/2#newcode60
src/scripts/archive_hwqual.sh:60: tar cjf
"${FLAGS_from}/${FLAGS_output_tag}.tar.bz2" .
On 2010/03/09 20:59:14, aluri wrote:
> -j, --bzip2
>               filter archive through bzip2, use to decompress .bz2 files.  
> WARNING:  some previous versions of tar used option -I to filter through
bzip2. 
> When writing scripts, use --bzip2 instead of -j so that both older and newer
tar
> versions will work.
> 

Done.

http://codereview.chromium.org/716001/diff/1/2#newcode60
src/scripts/archive_hwqual.sh:60: tar cjf
"${FLAGS_from}/${FLAGS_output_tag}.tar.bz2" .
On 2010/03/09 07:28:43, petkov wrote:
> I'm not sure what the context of running this script is but you end up with a
> tarball in a temp directory. It doesn't seems like whoever invokes this script
> knows the complete path to the tarball.
> 

Actually it was also putting it back into --from directory, which was good
enough for its intended use, but I added an explicit --to option to make it
clear now.

[petkov, 2010-03-11 00:25:28]

LGTM

Btw, do we have a convention to not add .sh to new scripts?

[tedbo, 2010-03-11 00:45:17]

FYI

On Wed, Mar 10, 2010 at 4:25 PM,  <petkov@chromium.org> wrote:
> LGTM
>
> Btw, do we have a convention to not add .sh to new scripts?

I think so. I think the conventions is supposed to be that executables
have no extension while shell libraries should have a ".sh" extension
and not be executable.

I've been trying to follow this with all new scripts.

ted

>
>
> http://codereview.chromium.org/716001
>

[kmixter1, 2010-03-12 01:11:21]

PTAL

Stripped the .sh from the script name and added links to the manual testcases if
they are included.

[petkov, 2010-03-12 01:18:06]

LGTM

[kmixter1, 2010-03-12 22:45:53]

Making archive_build automatically run archive_hwqual when --official_image is
passed.  Submitting.