Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Unified Diff: gpu/command_buffer/build_gles2_cmd_buffer.py

Issue 7158002: Revert 89002 - Enforce RGB even on buggy drivers. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 9 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | gpu/command_buffer/service/framebuffer_manager.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gpu/command_buffer/build_gles2_cmd_buffer.py
===================================================================
--- gpu/command_buffer/build_gles2_cmd_buffer.py (revision 89013)
+++ gpu/command_buffer/build_gles2_cmd_buffer.py (working copy)
@@ -1134,7 +1134,7 @@
'decoder_func': 'DoClearDepthf',
'gl_test_func': 'glClearDepth',
},
- 'ColorMask': {'decoder_func': 'DoColorMask', 'expectation': False},
+ 'ColorMask': {'decoder_func': 'DoColorMask'},
'ClearStencil': {'decoder_func': 'DoClearStencil'},
'CommandBufferEnableCHROMIUM': {
'type': 'Custom',
@@ -1192,7 +1192,7 @@
},
'DeleteTextures': {'type': 'DELn'},
'DepthRangef': {'decoder_func': 'glDepthRange'},
- 'DepthMask': {'decoder_func': 'DoDepthMask', 'expectation': False},
+ 'DepthMask': {'decoder_func': 'DoDepthMask'},
'DetachShader': {'decoder_func': 'DoDetachShader'},
'Disable': {
'decoder_func': 'DoDisable',
@@ -1507,11 +1507,8 @@
'cmd_args':
'GLuint shader, const char* data',
},
- 'StencilMask': {'decoder_func': 'DoStencilMask', 'expectation': False},
- 'StencilMaskSeparate': {
- 'decoder_func': 'DoStencilMaskSeparate',
- 'expectation': False,
- },
+ 'StencilMask': {'decoder_func': 'DoStencilMask'},
+ 'StencilMaskSeparate': {'decoder_func': 'DoStencilMaskSeparate'},
'SwapBuffers': {
'type': 'Custom',
'impl_func': False,
@@ -4274,22 +4271,6 @@
"""Gets the bucket version of this argument."""
return self
-
-class BoolArgument(Argument):
- """class for GLboolean"""
-
- def __init__(self, name, type):
- Argument.__init__(self, name, 'GLboolean')
-
- def GetValidArg(self, func, offset, index):
- """Gets a valid value for this argument."""
- return 'true'
-
- def GetValidGLArg(self, func, offset, index):
- """Gets a valid GL value for this argument."""
- return 'true'
-
-
class DataSizeArgument(Argument):
"""class for data_size which Bucket commands do not need."""
@@ -4354,7 +4335,7 @@
class EnumBaseArgument(Argument):
- """Base class for EnumArgument, IntArgument and ValidatedBoolArgument"""
+ """Base class for EnumArgument, IntArgument and BoolArgument"""
def __init__(self, name, gl_type, type, gl_error):
Argument.__init__(self, name, gl_type)
@@ -4424,7 +4405,7 @@
EnumBaseArgument.__init__(self, name, "GLint", type, "GL_INVALID_VALUE")
-class ValidatedBoolArgument(EnumBaseArgument):
+class BoolArgument(EnumBaseArgument):
"""A class for a GLboolean argument that can only except specific values.
For example glUniformMatrix takes a GLboolean for it's transpose but it
@@ -5078,8 +5059,6 @@
elif arg_parts[0].startswith('GLenum') and len(arg_parts[0]) > 6:
return EnumArgument(arg_parts[-1], " ".join(arg_parts[0:-1]))
elif arg_parts[0].startswith('GLboolean') and len(arg_parts[0]) > 9:
- return ValidatedBoolArgument(arg_parts[-1], " ".join(arg_parts[0:-1]))
- elif arg_parts[0].startswith('GLboolean'):
return BoolArgument(arg_parts[-1], " ".join(arg_parts[0:-1]))
elif (arg_parts[0].startswith('GLint') and len(arg_parts[0]) > 5 and
not arg_parts[0].startswith('GLintptr')):
« no previous file with comments | « no previous file | gpu/command_buffer/service/framebuffer_manager.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698