Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1304)

Unified Diff: content/renderer/media/audio_input_message_filter.h

Issue 7157001: Implements AudioMessageFilter as member in RenderThread (Closed) Base URL: http://src.chromium.org/svn/trunk/src/
Patch Set: Fixed nits in AudioRenderImpl unit test Created 9 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/renderer/media/audio_input_device.cc ('k') | content/renderer/media/audio_input_message_filter.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/media/audio_input_message_filter.h
===================================================================
--- content/renderer/media/audio_input_message_filter.h (revision 92113)
+++ content/renderer/media/audio_input_message_filter.h (working copy)
@@ -4,7 +4,7 @@
//
// MessageFilter that handles audio input messages and delegates them to
// audio capturers. Created on render thread, AudioMessageFilter is operated on
-// IO thread (main thread of render process), it intercepts audio messages
+// IO thread (secondary thread of render process), it intercepts audio messages
// and process them on IO thread since these messages are time critical.
// This implementation only supports low-latency (based on SyncSocket)
// messaging.
@@ -39,7 +39,7 @@
virtual ~Delegate() {}
};
- explicit AudioInputMessageFilter(int32 route_id);
+ AudioInputMessageFilter();
virtual ~AudioInputMessageFilter();
// Add a delegate to the map and return id of the entry.
@@ -51,11 +51,7 @@
// Sends an IPC message using |channel_|.
bool Send(IPC::Message* message);
- MessageLoop* message_loop() { return message_loop_; }
-
private:
- // TODO(henrika): add unit tests (compare with AudioMessageFilter)
-
// IPC::ChannelProxy::MessageFilter override. Called on IO thread.
virtual bool OnMessageReceived(const IPC::Message& message);
virtual void OnFilterAdded(IPC::Channel* channel);
@@ -80,11 +76,7 @@
IPC::Channel* channel_;
- int32 route_id_;
-
- MessageLoop* message_loop_;
-
- DISALLOW_IMPLICIT_CONSTRUCTORS(AudioInputMessageFilter);
+ DISALLOW_COPY_AND_ASSIGN(AudioInputMessageFilter);
};
#endif // CONTENT_RENDERER_MEDIA_AUDIO_INPUT_MESSAGE_FILTER_H_
« no previous file with comments | « content/renderer/media/audio_input_device.cc ('k') | content/renderer/media/audio_input_message_filter.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698