Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 7149017: Cleanup OriginIdentifierValueMap code. (Closed)

Created:
9 years, 6 months ago by markusheintz_
Modified:
9 years, 6 months ago
CC:
chromium-reviews, jochen (gone - plz use gerrit)
Visibility:
Public.

Description

Cleanup OriginIdentifierValueMap code. BUG=none TEST=host_content_settings_map_unittest.cc, origin_identifier_value_map_unittests.cc Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=89324

Patch Set 1 #

Patch Set 2 : " #

Total comments: 2

Patch Set 3 : " #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -20 lines) Patch
M chrome/browser/content_settings/content_settings_origin_identifier_value_map.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/content_settings/content_settings_origin_identifier_value_map.cc View 1 2 chunks +3 lines, -12 lines 0 comments Download
M chrome/browser/content_settings/content_settings_origin_identifier_value_map_unittest.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/content_settings/content_settings_pref_provider.cc View 1 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
markusheintz_
Please review this CL http://codereview.chromium.org/7149017/diff/2001/chrome/browser/content_settings/content_settings_origin_identifier_value_map.h File chrome/browser/content_settings/content_settings_origin_identifier_value_map.h (right): http://codereview.chromium.org/7149017/diff/2001/chrome/browser/content_settings/content_settings_origin_identifier_value_map.h#newcode99 chrome/browser/content_settings/content_settings_origin_identifier_value_map.h:99: EntryList::iterator erase(EntryList::iterator entry); Sorry I ...
9 years, 6 months ago (2011-06-14 12:50:40 UTC) #1
Bernhard Bauer
LGTM.
9 years, 6 months ago (2011-06-14 12:56:02 UTC) #2
commit-bot: I haz the power
9 years, 6 months ago (2011-06-14 15:30:01 UTC) #3
Try job failure for 7149017-6 on linux_clang for step compile:
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_clan...

Powered by Google App Engine
This is Rietveld 408576698