Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1685)

Unified Diff: chrome/browser/content_settings/content_settings_origin_identifier_value_map.cc

Issue 7149017: Cleanup OriginIdentifierValueMap code. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: " Created 9 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/content_settings/content_settings_origin_identifier_value_map.cc
diff --git a/chrome/browser/content_settings/content_settings_origin_identifier_value_map.cc b/chrome/browser/content_settings/content_settings_origin_identifier_value_map.cc
index b086f46b2421f3324625c3806008cc76d0cd2694..330ee4972724c9f4d4fe41b78e4e305482befdeb 100644
--- a/chrome/browser/content_settings/content_settings_origin_identifier_value_map.cc
+++ b/chrome/browser/content_settings/content_settings_origin_identifier_value_map.cc
@@ -27,9 +27,7 @@ OriginIdentifierValueMap::Entry::~Entry() {}
OriginIdentifierValueMap::OriginIdentifierValueMap() {}
-OriginIdentifierValueMap::~OriginIdentifierValueMap() {
- Clear();
-}
+OriginIdentifierValueMap::~OriginIdentifierValueMap() {}
bool operator>(const OriginIdentifierValueMap::Entry& first,
const OriginIdentifierValueMap::Entry& second) {
@@ -108,19 +106,12 @@ void OriginIdentifierValueMap::DeleteValue(
}
}
-void OriginIdentifierValueMap::Clear() {
+void OriginIdentifierValueMap::clear() {
// Delete all owned value objects.
- /*
- for (OriginIdentifierValueMap::iterator entry = entries_.begin();
- entry != entries_.end();
- ++entry) {
- delete entry->value;
- }
- */
entries_.clear();
}
-OriginIdentifierValueMap::iterator OriginIdentifierValueMap::DeleteValue(
+OriginIdentifierValueMap::iterator OriginIdentifierValueMap::erase(
OriginIdentifierValueMap::iterator entry) {
return entries_.erase(entry);
}

Powered by Google App Engine
This is Rietveld 408576698