Issue 7149008: Cleanup: base/scoped_ptr.h -> base/memory/scoped_ptr.h. (part 2)

Issue 7149008: Cleanup: base/scoped_ptr.h -> base/memory/scoped_ptr.h. (part 2) (Closed)

Created:
9 years, 6 months ago by Lei Zhang

Modified:
9 years, 6 months ago

Reviewers:
levin

CC:
chromium-reviews, jamiewalch+watch_chromium.org, garykac+watch_chromium.org, cbentzel+watch_chromium.org, simonmorris+watch_chromium.org, hclam+watch_chromium.org, wez+watch_chromium.org, dmaclach+watch_chromium.org, brettw-cc_chromium.org, jam, apatrick_chromium, joi+watch-content_chromium.org, lambroslambrou+watch_chromium.org, darin-cc_chromium.org, Paweł Hajdan Jr., ajwong+watch_chromium.org, sergeyu+watch_chromium.org, kinuko+watch

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Cleanup: base/scoped_ptr.h -> base/memory/scoped_ptr.h. (part 2) BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=89131

Patch Set 1 #

Patch Set 2 : fix lint #

Total comments: 4

Patch Set 3 : fix nits #

Created: 9 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+62 lines, -45 lines)			Patch
M	base/message_loop.cc	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	base/metrics/histogram_unittest.cc	View	1 2	1 chunk	+4 lines, -1 line	0 comments	Download
M	base/utf_offset_string_conversions.cc	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	content/browser/renderer_host/p2p/socket_host_tcp.h	View	1 2	1 chunk	+3 lines, -1 line	0 comments	Download
M	content/browser/renderer_host/p2p/socket_host_tcp_server.h	View	1 2	1 chunk	+2 lines, -1 line	0 comments	Download
M	content/browser/renderer_host/p2p/socket_host_udp.h	View	1 2	1 chunk	+2 lines, -1 line	0 comments	Download
M	content/common/gpu/transport_texture.h	View	1 2	2 chunks	+2 lines, -2 lines	0 comments	Download
M	content/ppapi_plugin/ppapi_webkitclient_impl.h	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	content/renderer/p2p/p2p_transport_impl.h	View	1 2	2 chunks	+4 lines, -2 lines	0 comments	Download
M	content/renderer/pepper_platform_video_decoder_impl.h	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	content/renderer/v8_value_converter.cc	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	content/renderer/v8_value_converter_browsertest.cc	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	content/renderer/webworker_base.h	View	1 2	2 chunks	+2 lines, -2 lines	0 comments	Download
M	content/worker/webworker_stub.h	View	1 2	1 chunk	+3 lines, -1 line	0 comments	Download
M	gpu/gles2_conform_support/egl/display.h	View	1 2	2 chunks	+4 lines, -4 lines	0 comments	Download
M	net/base/escape.cc	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	net/curvecp/client_packetizer.h	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	net/curvecp/packetizer.h	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	net/proxy/init_proxy_resolver.h	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	net/socket/server_socket.h	View	1 2	2 chunks	+2 lines, -2 lines	0 comments	Download
M	net/socket/tcp_client_socket_win.h	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	net/socket/tcp_server_socket_libevent.h	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	net/socket/tcp_server_socket_unittest.cc	View	1 2	1 chunk	+3 lines, -1 line	0 comments	Download
M	net/socket/tcp_server_socket_win.h	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	remoting/base/encoder_vp8_unittest.cc	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	remoting/host/chromoting_host_unittest.cc	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	webkit/fileapi/file_system_directory_database.h	View	1 2	3 chunks	+5 lines, -5 lines	0 comments	Download
M	webkit/fileapi/file_system_file_util.cc	View	1 2	3 chunks	+5 lines, -3 lines	0 comments	Download
M	webkit/fileapi/file_system_origin_database.h	View	1 2	2 chunks	+2 lines, -2 lines	0 comments	Download
M	webkit/plugins/ppapi/webkit_forwarding_impl.cc	View	1 2	1 chunk	+3 lines, -1 line	0 comments	Download
M	webkit/quota/mock_storage_client.cc	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

levin

LGTM http://codereview.chromium.org/7149008/diff/3009/base/metrics/histogram_unittest.cc File base/metrics/histogram_unittest.cc (right): http://codereview.chromium.org/7149008/diff/3009/base/metrics/histogram_unittest.cc#newcode7 base/metrics/histogram_unittest.cc:7: #include <algorithm> I'm surprised that you didn't add ...

9 years, 6 months ago (2011-06-14 07:35:05 UTC) #2

Lei Zhang

http://codereview.chromium.org/7149008/diff/3009/base/metrics/histogram_unittest.cc File base/metrics/histogram_unittest.cc (right): http://codereview.chromium.org/7149008/diff/3009/base/metrics/histogram_unittest.cc#newcode7 base/metrics/histogram_unittest.cc:7: #include <algorithm> On 2011/06/14 07:35:05, levin wrote: > I'm ...

9 years, 6 months ago (2011-06-14 18:57:34 UTC) #3

levin

9 years, 6 months ago (2011-06-14 20:26:26 UTC) #4

LGTM

(still) Just in case you were waiting for another :).

On 2011/06/14 18:57:34, Lei Zhang wrote:
>
http://codereview.chromium.org/7149008/diff/3009/base/metrics/histogram_unitt...
> File base/metrics/histogram_unittest.cc (right):
> 
>
http://codereview.chromium.org/7149008/diff/3009/base/metrics/histogram_unitt...
> base/metrics/histogram_unittest.cc:7: #include <algorithm>
> On 2011/06/14 07:35:05, levin wrote:
> > I'm surprised that you didn't add #include <vector> here as well. (That
would
> be
> > fine with me.)
> 
> Done. Not sure why the linter did not complain.
> 
>
http://codereview.chromium.org/7149008/diff/3009/content/renderer/p2p/p2p_tra...
> File content/renderer/p2p/p2p_transport_impl.h (right):
> 
>
http://codereview.chromium.org/7149008/diff/3009/content/renderer/p2p/p2p_tra...
> content/renderer/p2p/p2p_transport_impl.h:9: #include <vector>
> On 2011/06/14 07:35:05, levin wrote:
> > I don't see any uses of vector in this header.
> 
> Removed.

Expand Messages | Collapse Messages