Use ExecuteJavascriptInWebFrameNotifyResult to return results even in error condition

chrome/browser/ui/webui/web_ui_browsertest.cc

Index: chrome/browser/ui/webui/web_ui_browsertest.cc
diff --git a/chrome/browser/ui/webui/web_ui_browsertest.cc b/chrome/browser/ui/webui/web_ui_browsertest.cc
index 3817612619a61c8a7daf4884bbc5cab12a9f0e53..f7c45d2cb75f03265724967595f42d08861fa801 100644
--- a/chrome/browser/ui/webui/web_ui_browsertest.cc
+++ b/chrome/browser/ui/webui/web_ui_browsertest.cc
@@ -201,6 +201,14 @@ IN_PROC_BROWSER_TEST_F(WebUIBrowserTest, TestSamplePass) {
   ui_test_utils::NavigateToURL(browser(), GURL(chrome::kChromeUIDownloadsURL));
 
   ASSERT_TRUE(RunJavascriptTest("testAssertFalse"));
+  ASSERT_FALSE(RunJavascriptTest("FAILS_testAssertFalse"));
   ASSERT_TRUE(RunJavascriptTest("testInitialFocus"));
   ASSERT_FALSE(RunJavascriptTest("testConsoleError"));
 }
+
+// This fails on purpose to test hanging case in crbug.com/85990

[Paweł Hajdan Jr., 2011/06/15 15:49:30]

nit: Maybe put the "This fails on purpose" right above the ASSERT_FALSE (above
too). It might look weird if later someone marks the entire test as FAILS,
FLAKY, or DISABLED (hopefully that won't happen, but let's avoid a possible
confusion).

[Sheridan Rawlins, 2011/06/15 17:08:16]

I used the gtest-spi method EXPECT_FATAL_FAILURE along with SCOPED_TRACE to make
the failure expected (and pass only when fails).

On 2011/06/15 15:49:30, Paweł Hajdan Jr. wrote:

+IN_PROC_BROWSER_TEST_F(WebUIBrowserTest, TestFailsFast) {
+  AddLibrary(FilePath(FILE_PATH_LITERAL("sample_downloads.js")));
+  ui_test_utils::NavigateToURL(browser(), GURL(chrome::kChromeUIDownloadsURL));
+  ASSERT_FALSE(RunJavascriptTest("FAILS_BogusFunctionName"));
+}