Use ExecuteJavascriptInWebFrameNotifyResult to return results even in error condition

chrome/browser/ui/webui/web_ui_browsertest.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 #include "chrome/browser/ui/webui/web_ui_browsertest.h"
 
 #include <string>
 #include <vector>
 
 #include "base/path_service.h"
 #include "base/utf_string_conversions.h"
@@ skipping 183 matching lines @@
 }
 
 IN_PROC_BROWSER_TEST_F(WebUIBrowserTest, TestSamplePass) {
   AddLibrary(FilePath(FILE_PATH_LITERAL("sample_downloads.js")));
 
   // Navigate to UI.
   // TODO(dtseng): make accessor for subclasses to return?
   ui_test_utils::NavigateToURL(browser(), GURL(chrome::kChromeUIDownloadsURL));
 
   ASSERT_TRUE(RunJavascriptTest("testAssertFalse"));
+  ASSERT_FALSE(RunJavascriptTest("FAILS_testAssertFalse"));
   ASSERT_TRUE(RunJavascriptTest("testInitialFocus"));
   ASSERT_FALSE(RunJavascriptTest("testConsoleError"));
 }
+
+// This fails on purpose to test hanging case in crbug.com/85990

[Paweł Hajdan Jr., 2011/06/15 15:49:30]

nit: Maybe put the "This fails on purpose" right above the ASSERT_FALSE (above
too). It might look weird if later someone marks the entire test as FAILS,
FLAKY, or DISABLED (hopefully that won't happen, but let's avoid a possible
confusion).

[Sheridan Rawlins, 2011/06/15 17:08:16]

I used the gtest-spi method EXPECT_FATAL_FAILURE along with SCOPED_TRACE to make
the failure expected (and pass only when fails).

On 2011/06/15 15:49:30, Paweł Hajdan Jr. wrote:

+IN_PROC_BROWSER_TEST_F(WebUIBrowserTest, TestFailsFast) {
+  AddLibrary(FilePath(FILE_PATH_LITERAL("sample_downloads.js")));
+  ui_test_utils::NavigateToURL(browser(), GURL(chrome::kChromeUIDownloadsURL));
+  ASSERT_FALSE(RunJavascriptTest("FAILS_BogusFunctionName"));
+}