Issue 7144016: Simplify the author check.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7144016: Simplify the author check. (Closed)

Created:
9 years, 6 months ago by M-A Ruel

Modified:
9 years, 6 months ago

Reviewers:
Dirk Pranke, commit-bot: I haz the power

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Simplify the author check. 2 lines removed! R=dpranke@chromium.org BUG= TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=89182

Patch Set 1 #

Total comments: 2

Created: 9 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -3 lines)			Patch
	M	PRESUBMIT.py	View		1 chunk	+1 line, -3 lines	2 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Dirk Pranke

LGTM. http://codereview.chromium.org/7144016/diff/1/PRESUBMIT.py File PRESUBMIT.py (right): http://codereview.chromium.org/7144016/diff/1/PRESUBMIT.py#newcode114 PRESUBMIT.py:114: if not any(fnmatch.fnmatch(author.lower(), valid) for valid in valid_authors): ...

9 years, 6 months ago (2011-06-14 17:44:27 UTC) #2

M-A Ruel

http://codereview.chromium.org/7144016/diff/1/PRESUBMIT.py File PRESUBMIT.py (right): http://codereview.chromium.org/7144016/diff/1/PRESUBMIT.py#newcode114 PRESUBMIT.py:114: if not any(fnmatch.fnmatch(author.lower(), valid) for valid in valid_authors): On ...

9 years, 6 months ago (2011-06-14 18:06:30 UTC) #3

commit-bot: I haz the power

Try job failure for 7144016-1 on linux for step check_deps: http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux&number=31979

9 years, 6 months ago (2011-06-14 20:47:43 UTC) #4

Change committed as 89182

Expand Messages | Collapse Messages