Simplify the author check.

PRESUBMIT.py

 # Copyright (c) 2011 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Top-level presubmit script for Chromium.
 
 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts
 for more details about the presubmit API built into gcl.
 """
 
@@ skipping 93 matching lines @@
     input_api.logging.info('No author, skipping AUTHOR check')
     return []
   authors_path = input_api.os_path.join(
       input_api.PresubmitLocalPath(), 'AUTHORS')
   valid_authors = (
       input_api.re.match(r'[^#]+\s+\<(.+?)\>\s*$', line)
       for line in open(authors_path))
   valid_authors = [item.group(1).lower() for item in valid_authors if item]
   if input_api.verbose:
     print 'Valid authors are %s' % ', '.join(valid_authors)
-  if not any(
-      True for valid in valid_authors
-      if fnmatch.fnmatch(author.lower(), valid)):
+  if not any(fnmatch.fnmatch(author.lower(), valid) for valid in valid_authors):

[Dirk Pranke, 2011/06/14 17:44:27]

why is this fnmatch? authors aren't filenames ...

[M-A Ruel, 2011/06/14 18:06:30]

Yes but using wildcards is *much* easier than using a regexp. I could have made
a homebrew wildcard parser but it would have been more complex without gain.

     return [output_api.PresubmitPromptWarning(
         ('%s is not in AUTHORS file. If you are a new contributor, please visit'
         '\n'
         'http://www.chromium.org/developers/contributing-code and read the '
         '"Legal" section\n'
         'If you are a chromite, verify the contributor signed the CLA.') %
         author)]
   return []
 
 
@@ skipping 21 matching lines @@
   results.extend(input_api.canned_checks.CheckChangeHasBugField(
       input_api, output_api))
   results.extend(input_api.canned_checks.CheckChangeHasTestField(
       input_api, output_api))
   results.extend(_CheckSubversionConfig(input_api, output_api))
   return results
 
 
 def GetPreferredTrySlaves():
   return ['win', 'linux', 'mac']