Improve and unify Mac OS X run-time version checks

base/sys_info.h

Index: base/sys_info.h
===================================================================
--- base/sys_info.h	(revision 88826)
+++ base/sys_info.h	(working copy)
@@ -41,6 +41,11 @@
   // Retrieves detailed numeric values for the OS version.
   // TODO(port): Implement a Linux version of this method and enable the
   // corresponding unit test.
+  // DON'T USE THIS ON THE MAC OR WINDOWS to determine the current OS release
+  // for OS version-specific feature checks and workarounds. If you must use
+  // an OS version check instead of a feature check, use the base::mac::IsOS*
+  // family from base/mac/mac_util.h, or base::win::GetVersion from
+  // base/win/windows_version.h.

[Avi (use Gerrit), 2011/06/14 17:50:17]

Is there any use left for this function, then?

[Mark Mentovai, 2011/06/14 18:00:18]

Avi wrote:
Yes, there are still two or three mofos left that use it to format the version
number themselves. For example, the user agent string on Mac is formatted as
10_6_7.

I have a separate change (http://codereview.chromium.org/7150018) to transition
the Windows callers that were using this instead of the API I recommended. (On
Windows, OperatingSystemVersionNumbers is actually implemented on
base::win::OSInfo.)

   static void OperatingSystemVersionNumbers(int32* major_version,
                                             int32* minor_version,
                                             int32* bugfix_version);