Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2666)

Unified Diff: base/sys_info.h

Issue 7144007: Improve and unify Mac OS X run-time version checks (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: '' Created 9 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: base/sys_info.h
===================================================================
--- base/sys_info.h (revision 88826)
+++ base/sys_info.h (working copy)
@@ -41,6 +41,11 @@
// Retrieves detailed numeric values for the OS version.
// TODO(port): Implement a Linux version of this method and enable the
// corresponding unit test.
+ // DON'T USE THIS ON THE MAC OR WINDOWS to determine the current OS release
+ // for OS version-specific feature checks and workarounds. If you must use
+ // an OS version check instead of a feature check, use the base::mac::IsOS*
+ // family from base/mac/mac_util.h, or base::win::GetVersion from
+ // base/win/windows_version.h.
Avi (use Gerrit) 2011/06/14 17:50:17 Is there any use left for this function, then?
Mark Mentovai 2011/06/14 18:00:18 Avi wrote:
static void OperatingSystemVersionNumbers(int32* major_version,
int32* minor_version,
int32* bugfix_version);

Powered by Google App Engine
This is Rietveld 408576698