Issue 7134061: ui/base/models: Rewrite the TreeNodeModelTest.RemoveAllNodes unittest.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7134061: ui/base/models: Rewrite the TreeNodeModelTest.RemoveAllNodes unittest. (Closed)

Created:
9 years, 6 months ago by tfarina

Modified:
9 years, 6 months ago

Reviewers:
sky

CC:
chromium-reviews, Paweł Hajdan Jr.

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

ui/base/models: Rewrite the TreeNodeModelTest.RemoveAllNodes unittest. - This improves and simplifies the tests covered in RemoveAllNodes. BUG=None TEST=app_unittests --gtest_filter=TreeNodeModelTest.RemoveAllNodes R=sky@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=88672

Patch Set 1 : #

Patch Set 2 : #

Patch Set 3 : #

Total comments: 2

Patch Set 4 : add assertions for child1 & foo #

Patch Set 5 : better comment #

Created: 9 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+30 lines, -30 lines)			Patch
	M	ui/base/models/tree_node_model_unittest.cc	View	1 2 3 4	2 chunks	+30 lines, -30 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

sky

LGTM http://codereview.chromium.org/7134061/diff/3001/ui/base/models/tree_node_model_unittest.cc File ui/base/models/tree_node_model_unittest.cc (right): http://codereview.chromium.org/7134061/diff/3001/ui/base/models/tree_node_model_unittest.cc#newcode162 ui/base/models/tree_node_model_unittest.cc:162: ASSERT_TRUE(root.empty()); You should add assertions that child1 & ...

9 years, 6 months ago (2011-06-10 15:45:59 UTC) #2

tfarina

9 years, 6 months ago (2011-06-10 16:05:07 UTC) #3

http://codereview.chromium.org/7134061/diff/3001/ui/base/models/tree_node_mod...
File ui/base/models/tree_node_model_unittest.cc (right):

http://codereview.chromium.org/7134061/diff/3001/ui/base/models/tree_node_mod...
ui/base/models/tree_node_model_unittest.cc:162: ASSERT_TRUE(root.empty());
On 2011/06/10 15:45:59, sky wrote:
> You should add assertions that child1 & foo still have the expected number of
> children.

Done.

Expand Messages | Collapse Messages