ui/base/models: Rewrite the TreeNodeModelTest.RemoveAllNodes unittest.

ui/base/models/tree_node_model_unittest.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
+#include "base/basictypes.h"
 #include "base/string16.h"
-#include "base/string_number_conversions.h"
 #include "base/utf_string_conversions.h"
 #include "testing/gtest/include/gtest/gtest.h"
 #include "ui/base/models/tree_node_model.h"
 
 namespace ui {
 
 class TreeNodeModelTest : public testing::Test, public TreeModelObserver {
  public:
   TreeNodeModelTest()
       : added_count_(0),
@@ skipping 103 matching lines @@
 
   ASSERT_EQ(0, model.GetChildCount(root));
 }
 
 // Verify if the nodes added under the root are all deleted when calling
 // RemoveAll. Note that is responsability of the caller to free the memory
 // of the nodes removed after RemoveAll is called.
 // The tree looks like this:
 // root
 // |-- child1
-// |   |-- foo1
-// |       |-- child0
-// |       |-- child1
-// +-------|-- child2
+// |   |-- foo
+// |       |-- bar0
+// |       |-- bar1
+// |       |-- bar2
+// |-- child2
+// +-- child3
 TEST_F(TreeNodeModelTest, RemoveAllNodes) {
-  TreeNodeWithValue<int>* root =
-      new TreeNodeWithValue<int>(ASCIIToUTF16("root"), 0);
-  TreeNodeModel<TreeNodeWithValue<int> > model(root);
-  model.AddObserver(this);
-  ClearCounts();
+  TreeNodeWithValue<int> root;
 
-  // Create the first child node.
-  TreeNodeWithValue<int>* child1 =
-      new TreeNodeWithValue<int>(ASCIIToUTF16("child 1"), 1);
-  model.Add(root, child1, 0);
+  TreeNodeWithValue<int> child1;
+  TreeNodeWithValue<int> child2;
+  TreeNodeWithValue<int> child3;
 
-  TreeNodeWithValue<int>* foo1 =
-      new TreeNodeWithValue<int>(ASCIIToUTF16("foo1"), 2);
-  model.Add(child1, foo1, 0);
+  root.Add(&child1, 0);
+  root.Add(&child2, 1);
+  root.Add(&child3, 2);
 
-  // Add some nodes to |foo1|.
-  for (int i = 0; i < 3; ++i) {
-    model.Add(foo1,
-              new TreeNodeWithValue<int>(ASCIIToUTF16("child") +
-                                         base::IntToString16(i), i), i);
-  }
+  TreeNodeWithValue<int>* foo = new TreeNodeWithValue<int>(2);
+  child1.Add(foo, 0);
 
-  ASSERT_EQ(3, model.GetChildCount(foo1));
+  // Add some nodes to |foo|.
+  for (int i = 0; i < 3; ++i)
+    foo->Add(new TreeNodeWithValue<int>(i), i);
+
+  ASSERT_EQ(3, root.child_count());
+  ASSERT_EQ(1, child1.child_count());
+  ASSERT_EQ(3, foo->child_count());
 
   // Now remove all nodes from root.
-  root->RemoveAll();
+  root.RemoveAll();
 
-  // Release memory, so we don't leak.
-  delete child1;
-
-  ASSERT_EQ(0, model.GetChildCount(root));
+  ASSERT_EQ(0, root.child_count());
+  ASSERT_TRUE(root.empty());

[sky, 2011/06/10 15:45:59]

You should add assertions that child1 & foo still have the expected number of
children.

[tfarina, 2011/06/10 16:05:07]

Done.

 }
 
 // Verify if the model returns correct indexes for the specified nodes.
 // The tree looks like this:
 // root
 // |-- child1
 // |   |-- foo1
 // +-- child2
 TEST_F(TreeNodeModelTest, GetIndexOf) {
   TreeNodeWithValue<int> root;
@@ skipping 147 matching lines @@
 TEST_F(TreeNodeModelTest, IsRoot) {
   TreeNodeWithValue<int> root;
   EXPECT_TRUE(root.is_root());
 
   TreeNodeWithValue<int>* child1 = new TreeNodeWithValue<int>(1);
   root.Add(child1, root.child_count());
   EXPECT_FALSE(child1->is_root());
 }
 
 }  // namespace ui