chrome/browser/extensions/extension_tabs_module.h - Issue 7134035: Make an inserted selected tab selected before calling TabInsertedAt on observers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_tabs_module.h

Issue 7134035: Make an inserted selected tab selected before calling TabInsertedAt on observers. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: rename selected to active Created 9 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/extension_browser_event_router.cc ('K') | « chrome/browser/extensions/extension_browser_event_router.cc ('k') | chrome/browser/extensions/extension_tabs_module.cc » ('j') | chrome/browser/extensions/extension_tabs_module.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/extension_tabs_module.h

diff --git a/chrome/browser/extensions/extension_tabs_module.h b/chrome/browser/extensions/extension_tabs_module.h

index b406a9e5fb10e30a272de64342033cc3e11c9ec5..22f38656ac8f65aa63c3e37f609f22d41e6489bf 100644

--- a/chrome/browser/extensions/extension_tabs_module.h

+++ b/chrome/browser/extensions/extension_tabs_module.h

@@ -32,6 +32,9 @@ DictionaryValue* CreateTabValue(const TabContents* tab_contents);

DictionaryValue* CreateTabValue(const TabContents* tab_contents,

TabStripModel* tab_strip,

int tab_index);

+// Create a tab value, overriding its kSelectedKey to the provided boolean.

+DictionaryValue* CreateTabValueActive(const TabContents* tab_contents,

+ bool selected);

sky 2011/06/10 14:58:59 selected -> active

Yoyo Zhou 2011/06/10 18:04:01 Done.

DictionaryValue* CreateWindowValue(const Browser* browser,

bool populate_tabs);