Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(204)

Side by Side Diff: chrome/browser/extensions/extension_tabs_module.h

Issue 7134035: Make an inserted selected tab selected before calling TabInsertedAt on observers. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rename selected to active Created 9 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_EXTENSIONS_EXTENSION_TABS_MODULE_H__ 5 #ifndef CHROME_BROWSER_EXTENSIONS_EXTENSION_TABS_MODULE_H__
6 #define CHROME_BROWSER_EXTENSIONS_EXTENSION_TABS_MODULE_H__ 6 #define CHROME_BROWSER_EXTENSIONS_EXTENSION_TABS_MODULE_H__
7 #pragma once 7 #pragma once
8 8
9 #include <string> 9 #include <string>
10 10
(...skipping 14 matching lines...) Expand all
25 namespace ExtensionTabUtil { 25 namespace ExtensionTabUtil {
26 int GetWindowId(const Browser* browser); 26 int GetWindowId(const Browser* browser);
27 int GetTabId(const TabContents* tab_contents); 27 int GetTabId(const TabContents* tab_contents);
28 std::string GetTabStatusText(bool is_loading); 28 std::string GetTabStatusText(bool is_loading);
29 int GetWindowIdOfTab(const TabContents* tab_contents); 29 int GetWindowIdOfTab(const TabContents* tab_contents);
30 ListValue* CreateTabList(const Browser* browser); 30 ListValue* CreateTabList(const Browser* browser);
31 DictionaryValue* CreateTabValue(const TabContents* tab_contents); 31 DictionaryValue* CreateTabValue(const TabContents* tab_contents);
32 DictionaryValue* CreateTabValue(const TabContents* tab_contents, 32 DictionaryValue* CreateTabValue(const TabContents* tab_contents,
33 TabStripModel* tab_strip, 33 TabStripModel* tab_strip,
34 int tab_index); 34 int tab_index);
35 // Create a tab value, overriding its kSelectedKey to the provided boolean.
36 DictionaryValue* CreateTabValueActive(const TabContents* tab_contents,
37 bool selected);
sky 2011/06/10 14:58:59 selected -> active
Yoyo Zhou 2011/06/10 18:04:01 Done.
35 DictionaryValue* CreateWindowValue(const Browser* browser, 38 DictionaryValue* CreateWindowValue(const Browser* browser,
36 bool populate_tabs); 39 bool populate_tabs);
37 // Gets the |tab_strip_model| and |tab_index| for the given |tab_contents|. 40 // Gets the |tab_strip_model| and |tab_index| for the given |tab_contents|.
38 bool GetTabStripModel(const TabContents* tab_contents, 41 bool GetTabStripModel(const TabContents* tab_contents,
39 TabStripModel** tab_strip_model, 42 TabStripModel** tab_strip_model,
40 int* tab_index); 43 int* tab_index);
41 bool GetDefaultTab(Browser* browser, TabContentsWrapper** contents, 44 bool GetDefaultTab(Browser* browser, TabContentsWrapper** contents,
42 int* tab_id); 45 int* tab_id);
43 // Any out parameter (|browser|, |tab_strip|, |contents|, & |tab_index|) may 46 // Any out parameter (|browser|, |tab_strip|, |contents|, & |tab_index|) may
44 // be NULL and will not be set within the function. 47 // be NULL and will not be set within the function.
(...skipping 126 matching lines...) Expand 10 before | Expand all | Expand 10 after
171 // The format (JPEG vs PNG) of the resulting image. Set in RunImpl(). 174 // The format (JPEG vs PNG) of the resulting image. Set in RunImpl().
172 ImageFormat image_format_; 175 ImageFormat image_format_;
173 176
174 // Quality setting to use when encoding jpegs. Set in RunImpl(). 177 // Quality setting to use when encoding jpegs. Set in RunImpl().
175 int image_quality_; 178 int image_quality_;
176 179
177 DECLARE_EXTENSION_FUNCTION_NAME("tabs.captureVisibleTab") 180 DECLARE_EXTENSION_FUNCTION_NAME("tabs.captureVisibleTab")
178 }; 181 };
179 182
180 #endif // CHROME_BROWSER_EXTENSIONS_EXTENSION_TABS_MODULE_H__ 183 #endif // CHROME_BROWSER_EXTENSIONS_EXTENSION_TABS_MODULE_H__
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698