Make an inserted selected tab selected before calling TabInsertedAt on observers.

chrome/browser/tabs/tab_strip_model.cc

Index: chrome/browser/tabs/tab_strip_model.cc
diff --git a/chrome/browser/tabs/tab_strip_model.cc b/chrome/browser/tabs/tab_strip_model.cc
index de8df7ff8a0a1c3618d3afb7c5f844aec280eaec..4b6a900a0a6a57fe005c892f54417abb8214365a 100644
--- a/chrome/browser/tabs/tab_strip_model.cc
+++ b/chrome/browser/tabs/tab_strip_model.cc
@@ -155,12 +155,14 @@ void TabStripModel::InsertTabContentsAt(int index,
   contents_data_.insert(contents_data_.begin() + index, data);
 
   selection_model_.IncrementFrom(index);
+  if (active) {

[sky, 2011/06/09 17:13:01]

I'm nervous of the effects of doing this on the TabStrip implementations. dpapad
is also in the middle of changing this code:
http://codereview.chromium.org/7033048/ .

Why can't the extension code use the boolean passed to TabInsertedAt?

[Yoyo Zhou, 2011/06/09 18:08:54]

It gets discarded in ExtensionBrowserEventRouter::TabCreatedAt. I'm not sure
why; we could certainly use it.

Actually, we seem to have related bugs with tab selection/activeness and window
focus, where the callback result value from creating a tab or window is derived
directly from the TabContents or Browser, which may not have actually become
active or focused yet.

It sounds like you're suggesting that in the result value, we should override
the TabContents or Browser's active/focused state with what it will become.

I'm not sure about the implications of telling the callback function that a tab
is active when it might not yet be in the UI. +asargent who might know more
about the timing of the tabs API.

+    selection_model_.SetSelectedIndex(index);
+  }
 
   FOR_EACH_OBSERVER(TabStripModelObserver, observers_,
                     TabInsertedAt(contents, index, active));
 
   if (active) {
-    selection_model_.SetSelectedIndex(index);
     NotifyTabSelectedIfChanged(selected_contents, index, false);
   }
 }