Make an inserted selected tab selected before calling TabInsertedAt on observers.

chrome/browser/tabs/tab_strip_model.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/tabs/tab_strip_model.h"
 
 #include <algorithm>
 #include <map>
 
 #include "base/command_line.h"
@@ skipping 137 matching lines @@
       // Forget any existing relationships, we don't want to make things too
       // confusing by having multiple groups active at the same time.
       ForgetAllOpeners();
     }
     data->opener = &selected_contents->controller();
   }
 
   contents_data_.insert(contents_data_.begin() + index, data);
 
   selection_model_.IncrementFrom(index);
+  if (active) {

[sky, 2011/06/09 17:13:01]

I'm nervous of the effects of doing this on the TabStrip implementations. dpapad
is also in the middle of changing this code:
http://codereview.chromium.org/7033048/ .

Why can't the extension code use the boolean passed to TabInsertedAt?

[Yoyo Zhou, 2011/06/09 18:08:54]

It gets discarded in ExtensionBrowserEventRouter::TabCreatedAt. I'm not sure
why; we could certainly use it.

Actually, we seem to have related bugs with tab selection/activeness and window
focus, where the callback result value from creating a tab or window is derived
directly from the TabContents or Browser, which may not have actually become
active or focused yet.

It sounds like you're suggesting that in the result value, we should override
the TabContents or Browser's active/focused state with what it will become.

I'm not sure about the implications of telling the callback function that a tab
is active when it might not yet be in the UI. +asargent who might know more
about the timing of the tabs API.

+    selection_model_.SetSelectedIndex(index);
+  }
 
   FOR_EACH_OBSERVER(TabStripModelObserver, observers_,
                     TabInsertedAt(contents, index, active));
 
   if (active) {
-    selection_model_.SetSelectedIndex(index);
     NotifyTabSelectedIfChanged(selected_contents, index, false);
   }
 }
 
 TabContentsWrapper* TabStripModel::ReplaceTabContentsAt(
     int index,
     TabContentsWrapper* new_contents) {
   DCHECK(ContainsIndex(index));
   TabContentsWrapper* old_contents = GetContentsAt(index);
 
@@ skipping 1137 matching lines @@
 void TabStripModel::ForgetOpenersAndGroupsReferencing(
     const NavigationController* tab) {
   for (TabContentsDataVector::const_iterator i = contents_data_.begin();
        i != contents_data_.end(); ++i) {
     if ((*i)->group == tab)
       (*i)->group = NULL;
     if ((*i)->opener == tab)
       (*i)->opener = NULL;
   }
 }