Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(871)

Issue 7134026: Multi-tab: Renaming TabStripModel::GetSelectedTabContents to GetActiveTabContents (Closed)

Created:
9 years, 6 months ago by dpapad
Modified:
9 years, 6 months ago
CC:
chromium-reviews, Aaron Boodman, Erik does not do reviews
Visibility:
Public.

Description

Multi-tab: Renaming TabStripModel::GetSelectedTabContents to GetActiveTabContents BUG=There was a TODO comment for that. TEST=NONE Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=88471

Patch Set 1 #

Patch Set 2 : Addint TODO comments #

Patch Set 3 : Renaming in tab_strip_model_unittest.cc too. #

Patch Set 4 : Renaming in tab_strip_controller.mm too. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -37 lines) Patch
M chrome/browser/extensions/extension_tabs_module.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/tabs/tab_strip_model.h View 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/browser/tabs/tab_strip_model.cc View 4 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/tabs/tab_strip_model_order_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/tabs/tab_strip_model_unittest.cc View 1 2 10 chunks +22 lines, -22 lines 0 comments Download
M chrome/browser/ui/browser.h View 1 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/browser/ui/browser.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/tabs/tab_strip_controller.mm View 1 2 3 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
dpapad
9 years, 6 months ago (2011-06-08 23:25:33 UTC) #1
sky
LGTM
9 years, 6 months ago (2011-06-08 23:29:37 UTC) #2
commit-bot: I haz the power
9 years, 6 months ago (2011-06-09 01:39:44 UTC) #3
Change committed as 88471

Powered by Google App Engine
This is Rietveld 408576698