Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2865)

Unified Diff: chrome/browser/ui/browser.h

Issue 7134026: Multi-tab: Renaming TabStripModel::GetSelectedTabContents to GetActiveTabContents (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Renaming in tab_strip_controller.mm too. Created 9 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/tabs/tab_strip_model_unittest.cc ('k') | chrome/browser/ui/browser.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/browser.h
diff --git a/chrome/browser/ui/browser.h b/chrome/browser/ui/browser.h
index 5ec471dd1bf70a94c2e921f13f338be92b376a11..8a9c9cdd6b86bab29101fdfb9fb7c956cd95a865 100644
--- a/chrome/browser/ui/browser.h
+++ b/chrome/browser/ui/browser.h
@@ -360,6 +360,7 @@ class Browser : public TabHandlerDelegate,
int tab_count() const;
int active_index() const;
int GetIndexOfController(const NavigationController* controller) const;
+ // TODO(dpapad): Rename to GetActiveTabContentsWrapper().
TabContentsWrapper* GetSelectedTabContentsWrapper() const;
TabContentsWrapper* GetTabContentsWrapperAt(int index) const;
// Same as above but correctly handles if GetSelectedTabContents() is NULL
@@ -368,6 +369,7 @@ class Browser : public TabHandlerDelegate,
// objects, but that would require changing about 50+ other files. In order
// to keep changes localized, the default is to return a TabContents. Note
// this differs from the TabStripModel because it has far fewer clients.
+ // TODO(dpapad): Rename to GetActiveTabContents().
TabContents* GetSelectedTabContents() const;
TabContents* GetTabContentsAt(int index) const;
void ActivateTabAt(int index, bool user_gesture);
« no previous file with comments | « chrome/browser/tabs/tab_strip_model_unittest.cc ('k') | chrome/browser/ui/browser.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698