Get URLRequestContext from the profile attached to the automation provider, not the default.

Get URLRequestContext from the profile attached to the automation provider, not the default. Use System request context if no profile context available.

BUG=64339
TEST=automation provider tests continue to work correctly.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=88668

[willchan no longer on Chromium, 2011-06-08 16:55:35]

Should this reference BUG=64339?

http://codereview.chromium.org/7134020/diff/1/chrome/browser/automation/autom...
File chrome/browser/automation/automation_provider.cc (right):

http://codereview.chromium.org/7134020/diff/1/chrome/browser/automation/autom...
chrome/browser/automation/automation_provider.cc:584: context_getter =
g_browser_process->system_request_context();
Profile always lazily creates a URLRequestContextGetter, so it should not be
necessary to use the system URLRequestContext.

The question is is |profile_| always non-NULL? I believe it "should" be, but I
don't know if that's actually the case. We need a CF person here to chime in.
I'm looping in ananta.

I think the original code was probably copied from somewhere else where it was
being defensive since it might be invoked really early or really late, when the
Profile hasn't been created yet, or when the Profile has already been deleted. I
don't believe those cases apply here.

[ananta, 2011-06-09 19:35:18]

The profile object is created in BrowserMain before the AutomationProvider
object is instantiated. It should be safe to deref the profile pointer here.

[Miranda Callahan, 2011-06-10 13:49:39]

On 2011/06/09 19:35:18, ananta wrote:
> The profile object is created in BrowserMain before the AutomationProvider
> object is instantiated. It should be safe to deref the profile pointer here.

Thanks, ananta!  willchan, please take another look?

[willchan no longer on Chromium, 2011-06-10 14:02:41]

LGTM

[commit-bot: I haz the power, 2011-06-10 15:28:55]

Change committed as 88668