Get URLRequestContext from the profile attached to the automation provider, not the default.

chrome/browser/automation/automation_provider.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/automation/automation_provider.h"
 
 #include <set>
 
 #include "base/callback.h"
 #include "base/debug/trace_event.h"
@@ skipping 561 matching lines @@
   }
 
  private:
   scoped_refptr<net::URLRequestContextGetter> request_context_getter_;
   std::string proxy_config_;
 };
 
 
 void AutomationProvider::SetProxyConfig(const std::string& new_proxy_config) {
   net::URLRequestContextGetter* context_getter =
-      Profile::GetDefaultRequestContext();
+      profile_->GetRequestContext();
   if (!context_getter) {
-    FilePath user_data_dir;
-    PathService::Get(chrome::DIR_USER_DATA, &user_data_dir);
-    ProfileManager* profile_manager = g_browser_process->profile_manager();
-    DCHECK(profile_manager);
-    Profile* profile = profile_manager->GetDefaultProfile(user_data_dir);
-    DCHECK(profile);
-    context_getter = profile->GetRequestContext();
+    context_getter = g_browser_process->system_request_context();

[willchan no longer on Chromium, 2011/06/08 16:55:35]

Profile always lazily creates a URLRequestContextGetter, so it should not be
necessary to use the system URLRequestContext.

The question is is |profile_| always non-NULL? I believe it "should" be, but I
don't know if that's actually the case. We need a CF person here to chime in.
I'm looping in ananta.

I think the original code was probably copied from somewhere else where it was
being defensive since it might be invoked really early or really late, when the
Profile hasn't been created yet, or when the Profile has already been deleted. I
don't believe those cases apply here.

   }
   DCHECK(context_getter);
 
   BrowserThread::PostTask(
       BrowserThread::IO, FROM_HERE,
       new SetProxyConfigTask(context_getter, new_proxy_config));
 }
 
 TabContents* AutomationProvider::GetTabContentsForHandle(
     int handle, NavigationController** tab) {
@@ skipping 371 matching lines @@
 
 void AutomationProvider::SaveAsAsync(int tab_handle) {
   NavigationController* tab = NULL;
   TabContents* tab_contents = GetTabContentsForHandle(tab_handle, &tab);
   if (tab_contents) {
     TabContentsWrapper* wrapper =
         TabContentsWrapper::GetCurrentWrapperForContents(tab_contents);
     wrapper->download_tab_helper()->OnSavePage();
   }
 }