Don't output warnings that don't output how to resolve them.

Don't output warnings that don't output how to resolve them.

If you run with -v 1 you'll see these extra warnings.

BUG=85603
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=88621

[glotov, 2011-06-10 00:08:12]

LGTM

I hope to have a look to the problem general solution shortly. If urgent -
please rise bug priority.

On Fri, Jun 10, 2011 at 2:41 AM, <evan@chromium.org> wrote:

> Reviewers: glotov,
>
> Description:
> Don't output warnings that don't output how to resolve them.
>
> If you run with -v 1 you'll see these extra warnings.
>
> BUG=85603
>
>
> Please review this at
http://codereview.chromium.**org/7129053/<http://codereview.chromium.org/7129...
>
> SVN Base:
svn://svn.chromium.org/chrome/**trunk/src<http://svn.chromium.org/chrome/trunk/src>
>
> Affected files:
>  M ui/base/gtk/g_object_**destructor_filo.cc
>
>
> Index: ui/base/gtk/g_object_**destructor_filo.cc
> diff --git a/ui/base/gtk/g_object_**destructor_filo.cc
> b/ui/base/gtk/g_object_**destructor_filo.cc
> index 3e37f60494326347b6c8c3034892f8**09a0cce0c2..**
> 592db80d6211d22d63ae5f9a86b979**178fc14bd0 100644
> --- a/ui/base/gtk/g_object_**destructor_filo.cc
> +++ b/ui/base/gtk/g_object_**destructor_filo.cc
> @@ -49,10 +49,12 @@ void GObjectDestructorFILO::**Disconnect(
>     return;
>   }
>   if (!dtors.front().equal(object, callback, context)) {
> -    LOG(WARNING) << "Destructors should be unregistered the reverse order
> they "
> -                 << "were registered. But for object " << object << " "
> -                 << "deleted hook is "<< context << ", the last queued
> hook is "
> -                 << dtors.front().context;
> +    // Reenable this warning once this bug is fixed:
> +    //
http://code.google.com/p/**chromium/issues/detail?id=**85603<http://code.goog...
> +    VLOG(1) << "Destructors should be unregistered the reverse order they
> "
> +            << "were registered. But for object " << object << " "
> +            << "deleted hook is "<< context << ", the last queued hook is
> "
> +            << dtors.front().context;
>   }
>   for (HandlerList::iterator i = dtors.begin(); i != dtors.end(); ++i) {
>     if (i->equal(object, callback, context)) {
>
>
>


-- 
Thank you,
Denis