Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(719)

Unified Diff: ui/base/gtk/g_object_destructor_filo.cc

Issue 7129053: Don't output warnings that don't output how to resolve them. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix Created 9 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/base/gtk/g_object_destructor_filo.cc
diff --git a/ui/base/gtk/g_object_destructor_filo.cc b/ui/base/gtk/g_object_destructor_filo.cc
index 3e37f60494326347b6c8c3034892f809a0cce0c2..592db80d6211d22d63ae5f9a86b979178fc14bd0 100644
--- a/ui/base/gtk/g_object_destructor_filo.cc
+++ b/ui/base/gtk/g_object_destructor_filo.cc
@@ -49,10 +49,12 @@ void GObjectDestructorFILO::Disconnect(
return;
}
if (!dtors.front().equal(object, callback, context)) {
- LOG(WARNING) << "Destructors should be unregistered the reverse order they "
- << "were registered. But for object " << object << " "
- << "deleted hook is "<< context << ", the last queued hook is "
- << dtors.front().context;
+ // Reenable this warning once this bug is fixed:
+ // http://code.google.com/p/chromium/issues/detail?id=85603
+ VLOG(1) << "Destructors should be unregistered the reverse order they "
+ << "were registered. But for object " << object << " "
+ << "deleted hook is "<< context << ", the last queued hook is "
+ << dtors.front().context;
}
for (HandlerList::iterator i = dtors.begin(); i != dtors.end(); ++i) {
if (i->equal(object, callback, context)) {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698