Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 7129048: Zero-sized windows are bad. Don't. (Closed)

Created:
9 years, 6 months ago by Avi (use Gerrit)
Modified:
9 years, 6 months ago
Reviewers:
Mark Mentovai, sail
CC:
chromium-reviews, pam+watch_chromium.org
Visibility:
Public.

Description

Zero-sized windows are bad. Don't. BUG=78973 TEST=as in bug. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=88638

Patch Set 1 #

Total comments: 4

Patch Set 2 : don't adjust view #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M chrome/browser/ui/cocoa/status_bubble_mac.mm View 1 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Avi (use Gerrit)
9 years, 6 months ago (2011-06-09 21:52:57 UTC) #1
Mark Mentovai
LGTM. Nice rect.
9 years, 6 months ago (2011-06-09 21:58:30 UTC) #2
sail
http://codereview.chromium.org/7129048/diff/1/chrome/browser/ui/cocoa/status_bubble_mac.mm File chrome/browser/ui/cocoa/status_bubble_mac.mm (right): http://codereview.chromium.org/7129048/diff/1/chrome/browser/ui/cocoa/status_bubble_mac.mm#newcode370 chrome/browser/ui/cocoa/status_bubble_mac.mm:370: [[BubbleView alloc] initWithFrame:NSMakeRect(0, 0, 1, 1) Are you sure ...
9 years, 6 months ago (2011-06-10 01:04:24 UTC) #3
Avi (use Gerrit)
http://codereview.chromium.org/7129048/diff/1/chrome/browser/ui/cocoa/status_bubble_mac.mm File chrome/browser/ui/cocoa/status_bubble_mac.mm (right): http://codereview.chromium.org/7129048/diff/1/chrome/browser/ui/cocoa/status_bubble_mac.mm#newcode370 chrome/browser/ui/cocoa/status_bubble_mac.mm:370: [[BubbleView alloc] initWithFrame:NSMakeRect(0, 0, 1, 1) On 2011/06/10 01:04:24, ...
9 years, 6 months ago (2011-06-10 01:20:27 UTC) #4
Avi (use Gerrit)
9 years, 6 months ago (2011-06-10 01:42:57 UTC) #5 
sail-

Good point tho. Try this out. Still compiling it on my two-core MacBook Pro.
(sigh)

Powered by Google App Engine
This is Rietveld 408576698