Zero-sized windows are bad. Don't.

chrome/browser/ui/cocoa/status_bubble_mac.mm

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/cocoa/status_bubble_mac.h"
 
 #include <limits>
 
 #include "base/compiler_specific.h"
 #include "base/message_loop.h"
@@ skipping 334 matching lines @@
     SetFrameAvoidingMouse([window_ frame], location);
 }
 
 void StatusBubbleMac::UpdateDownloadShelfVisibility(bool visible) {
   UpdateSizeAndPosition();
 }
 
 void StatusBubbleMac::Create() {
   DCHECK(!window_);
 
-  window_ = [[NSWindow alloc] initWithContentRect:NSZeroRect
+  window_ = [[NSWindow alloc] initWithContentRect:NSMakeRect(0, 0, 1, 1)
                                         styleMask:NSBorderlessWindowMask
                                           backing:NSBackingStoreBuffered
                                             defer:YES];
   [window_ setMovableByWindowBackground:NO];
   [window_ setBackgroundColor:[NSColor clearColor]];
   [window_ setLevel:NSNormalWindowLevel];
   [window_ setOpaque:NO];
   [window_ setHasShadow:NO];
 
   // We do not need to worry about the bubble outliving |parent_| because our
   // teardown sequence in BWC guarantees that |parent_| outlives the status
   // bubble and that the StatusBubble is torn down completely prior to the
   // window going away.
   scoped_nsobject<BubbleView> view(
-      [[BubbleView alloc] initWithFrame:NSZeroRect themeProvider:parent_]);
+      [[BubbleView alloc] initWithFrame:NSMakeRect(0, 0, 1, 1)

[sail, 2011/06/10 01:04:24]

Are you sure we need this? I create zero rect views all the time.

[Avi (use Gerrit), 2011/06/10 01:20:27]

Zero-rect views are fine. I wanted to change this too to match the window it's
going into. It probably doesn't matter anyway; the docs from -setContentView:
say that the view is resized to match the window size.

+                          themeProvider:parent_]);
   [window_ setContentView:view];
 
   [window_ setAlphaValue:0.0];
 
   // Set a delegate for the fade-in and fade-out transitions to be notified
   // when fades are complete.  The ownership model is for window_ to own
   // animation_dictionary, which owns animation, which owns
   // animation_delegate.
   CAAnimation* animation = [[window_ animationForKey:kFadeAnimationKey] copy];
   [animation autorelease];
@@ skipping 48 matching lines @@
       SetState(kBubbleHidden);
     }
   }
 }
 
 void StatusBubbleMac::SetState(StatusBubbleState state) {
   if (state == state_)
     return;
 
   if (state == kBubbleHidden)
-    [window_ setFrame:NSZeroRect display:YES];
+    [window_ setFrame:NSMakeRect(0, 0, 1, 1) display:YES];

[sail, 2011/06/10 01:04:24]

will this be visible?

[Avi (use Gerrit), 2011/06/10 01:20:27]

No, I checked. The bubble's faded to zero opacity at this point.

 
   if ([delegate_ respondsToSelector:@selector(statusBubbleWillEnterState:)])
     [delegate_ statusBubbleWillEnterState:state];
 
   state_ = state;
 }
 
 void StatusBubbleMac::Fade(bool show) {
   DCHECK([NSThread isMainThread]);
 
@@ skipping 233 matching lines @@
 
   if (expanded_width) {
     size.width = screenRect.size.width;
   } else {
     size.width = kWindowWidthPercent * screenRect.size.width;
   }
 
   screenRect.size = size;
   return screenRect;
 }