Issue 7129022: Move last of event handlers down to NativeWidgetWin/Gtk.

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+769 lines, -931 lines)			Patch
M	chrome/browser/ui/views/frame/browser_frame_gtk.h	View	1 2 3 4 5 6 7 8 9	1 chunk	+2 lines, -2 lines	0 comments	Download
M	views/widget/native_widget.h	View	1 2 3 4 5 6 7 8 9	1 chunk	+3 lines, -0 lines	0 comments	Download
M	views/widget/native_widget_delegate.h	View	1 2 3 4 5 6 7 8 9	1 chunk	+6 lines, -0 lines	0 comments	Download
M	views/widget/native_widget_gtk.h	View	1 2 3 4 5 6 7 8 9	3 chunks	+6 lines, -0 lines	0 comments	Download
M	views/widget/native_widget_gtk.cc	View	1 2 3 4 5 6 7 8 9	11 chunks	+163 lines, -0 lines	0 comments	Download
M	views/widget/native_widget_views.h	View	1 2 3 4 5 6 7 8 9	1 chunk	+1 line, -0 lines	0 comments	Download
M	views/widget/native_widget_views.cc	View	1 2 3 4 5 6 7 8 9	1 chunk	+4 lines, -0 lines	0 comments	Download
M	views/widget/native_widget_win.h	View	1 2 3 4 5 6 7 8 9	5 chunks	+32 lines, -0 lines	0 comments	Download
M	views/widget/native_widget_win.cc	View	1 2 3 4 5 6 7 8 9	15 chunks	+420 lines, -7 lines	0 comments	Download
M	views/widget/native_widget_win_unittest.cc	View	1 2 3 4 5 6 7 8 9	1 chunk	+1 line, -1 line	0 comments	Download
M	views/widget/widget.h	View	1 2 3 4 5 6 7 8 9	5 chunks	+25 lines, -1 line	0 comments	Download
M	views/widget/widget.cc	View	1 2 3 4 5 6 7 8 9	9 chunks	+103 lines, -7 lines	0 comments	Download
M	views/window/native_window.h	View	1 2 3 4 5 6 7 8 9	1 chunk	+0 lines, -3 lines	0 comments	Download
M	views/window/native_window_delegate.h	View	1 2 3 4 5 6 7 8 9	1 chunk	+0 lines, -9 lines	0 comments	Download
M	views/window/native_window_gtk.h	View	1 2 3 4 5 6 7 8 9	2 chunks	+0 lines, -43 lines	0 comments	Download
M	views/window/native_window_gtk.cc	View	1 2 3 4 5 6 7 8 9	5 chunks	+1 line, -202 lines	0 comments	Download
M	views/window/native_window_win.h	View	1 2 3 4 5 6 7 8 9	4 chunks	+0 lines, -61 lines	0 comments	Download
M	views/window/native_window_win.cc	View	1 2 3 4 5 6 7 8 9	5 chunks	+1 line, -468 lines	0 comments	Download
M	views/window/window.h	View	1 2 3 4 5 6 7 8 9	3 chunks	+0 lines, -25 lines	0 comments	Download
M	views/window/window.cc	View	1 2 3 4 5 6 7 8 9	5 chunks	+1 line, -102 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

tfarina

9 years, 6 months ago (2011-06-08 22:30:42 UTC) #3

http://codereview.chromium.org/7129022/diff/67/views/widget/native_widget.h
File views/widget/native_widget.h (right):

http://codereview.chromium.org/7129022/diff/67/views/widget/native_widget.h#n...
views/widget/native_widget.h:165: // Makes the NativeWindow modal.
nit: NativeWindow -> NativeWidget?

http://codereview.chromium.org/7129022/diff/67/views/window/native_window_del...
File views/window/native_window_delegate.h (right):

http://codereview.chromium.org/7129022/diff/67/views/window/native_window_del...
views/window/native_window_delegate.h:26: //
while you are here, remove this // ? Below too?

http://codereview.chromium.org/7129022/diff/67/views/window/window.h
File views/window/window.h (right):

http://codereview.chromium.org/7129022/diff/67/views/window/window.h#newcode82
views/window/window.h:82: #endif  // #ifndef VIEWS_WINDOW_WINDOW_H_
super minor nit: remove #ifndef?

Expand Messages | Collapse Messages