Issue 7124008: Fix identification of webstore extension.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7124008: Fix identification of webstore extension. (Closed)

Created:
9 years, 6 months ago by dgozman%chromium.org

Modified:
9 years, 6 months ago

Reviewers:
dgozman, jstritar, Evan Stade

CC:
chromium-reviews, estade+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Fix identification of webstore extension. BUG=chromium-os:15842 TEST=Observe single webstore on NTP. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=88318

Patch Set 1 #

Created: 9 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	chrome/browser/ui/webui/ntp/app_launcher_handler.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

dgozman

Hello Evan, May you have a look please? You looked at the previous patch http://codereview.chromium.org/6912024/, ...

9 years, 6 months ago (2011-06-07 10:37:34 UTC) #1

jstritar

9 years, 6 months ago (2011-06-08 20:05:59 UTC) #3

On 2011/06/07 15:18:32, Evan Stade wrote:
> lgtm

Looks like we get multiple web store icons on regular chrome builds now. Are the
web store launch URLs different on chrome and chrome OS for some reason?

Expand Messages | Collapse Messages