Support for component extensions as apps on the new tab page. Added filebrowser.

Support for component extensions as apps on the new tab page. Added filebrowser.

BUG=chromium-os:14543
TEST=File Manager should be on NTP.
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=86621

[dgozman, 2011-05-03 15:33:28]

Hello,

I'm not sure whom to ask for review, so included both Jon and Erik.
May you have a look?

Thanks,
Dmitry

[Evan Stade, 2011-05-03 17:02:55]

lgtm (but I am not an owner)

http://codereview.chromium.org/6912024/diff/1005/chrome/browser/resources/ntp...
File chrome/browser/resources/ntp/apps.js (right):

http://codereview.chromium.org/6912024/diff/1005/chrome/browser/resources/ntp...
chrome/browser/resources/ntp/apps.js:708: if (app['is_component']) {
probably clearer to do (here and below):

// User cannot change launch options or uninstall component extension.
if (!app['is_component']) {
  // settingsButton init
}

return div;

[arv (Not doing code reviews), 2011-05-03 21:51:57]

LGTM

[Nirnimesh, 2011-05-03 22:06:50]

http://codereview.chromium.org/6912024/diff/1005/chrome/test/functional/ntp.py
File chrome/test/functional/ntp.py (right):

http://codereview.chromium.org/6912024/diff/1005/chrome/test/functional/ntp.p...
chrome/test/functional/ntp.py:22: _EXPECTED_DEFAULT_APPS.append({u'name': u'File
Manager'})
If you don't mind could you run these tests to confirm that everything passes
please?

run_remote_tests.sh --target IP desktopui_PyAutoFunctionalTests

[dgozman, 2011-05-24 12:55:20]

http://codereview.chromium.org/6912024/diff/1005/chrome/browser/resources/ntp...
File chrome/browser/resources/ntp/apps.js (right):

http://codereview.chromium.org/6912024/diff/1005/chrome/browser/resources/ntp...
chrome/browser/resources/ntp/apps.js:708: if (app['is_component']) {
On 2011/05/03 17:02:55, Evan Stade wrote:
> probably clearer to do (here and below):
> 
> // User cannot change launch options or uninstall component extension.
> if (!app['is_component']) {
>   // settingsButton init
> }
> 
> return div;
>   

Done.

http://codereview.chromium.org/6912024/diff/1005/chrome/test/functional/ntp.py
File chrome/test/functional/ntp.py (right):

http://codereview.chromium.org/6912024/diff/1005/chrome/test/functional/ntp.p...
chrome/test/functional/ntp.py:22: _EXPECTED_DEFAULT_APPS.append({u'name': u'File
Manager'})
On 2011/05/03 22:06:50, Nirnimesh wrote:
> If you don't mind could you run these tests to confirm that everything passes
> please?
> 
> run_remote_tests.sh --target IP desktopui_PyAutoFunctionalTests

Ok, I run these tests. But they succeed, if I comment 'Get Started', so there
are only 'Web Store' and 'File Manager'.
Do you know, is it ok, or it just works strange on my device?

[Nirnimesh, 2011-05-24 17:29:42]

http://codereview.chromium.org/6912024/diff/1005/chrome/test/functional/ntp.py
File chrome/test/functional/ntp.py (right):

http://codereview.chromium.org/6912024/diff/1005/chrome/test/functional/ntp.p...
chrome/test/functional/ntp.py:22: _EXPECTED_DEFAULT_APPS.append({u'name': u'File
Manager'})
On 2011/05/24 12:55:21, dgozman wrote:
> On 2011/05/03 22:06:50, Nirnimesh wrote:
> > If you don't mind could you run these tests to confirm that everything
passes
> > please?
> > 
> > run_remote_tests.sh --target IP desktopui_PyAutoFunctionalTests
> 
> Ok, I run these tests. But they succeed, if I comment 'Get Started', so there
> are only 'Web Store' and 'File Manager'.
> Do you know, is it ok, or it just works strange on my device?

Did you emerge chromeos-chrome after commenting 'Get started'?
Anyway, commit it, and I'll let you know if something breaks. I don't expect it
to.

[dgozman, 2011-05-25 11:07:25]

On 2011/05/24 17:29:42, Nirnimesh wrote:
> http://codereview.chromium.org/6912024/diff/1005/chrome/test/functional/ntp.py
> File chrome/test/functional/ntp.py (right):
> 
>
http://codereview.chromium.org/6912024/diff/1005/chrome/test/functional/ntp.p...
> chrome/test/functional/ntp.py:22: _EXPECTED_DEFAULT_APPS.append({u'name':
u'File
> Manager'})
> On 2011/05/24 12:55:21, dgozman wrote:
> > On 2011/05/03 22:06:50, Nirnimesh wrote:
> > > If you don't mind could you run these tests to confirm that everything
> passes
> > > please?
> > > 
> > > run_remote_tests.sh --target IP desktopui_PyAutoFunctionalTests
> > 
> > Ok, I run these tests. But they succeed, if I comment 'Get Started', so
there
> > are only 'Web Store' and 'File Manager'.
> > Do you know, is it ok, or it just works strange on my device?
> 
> Did you emerge chromeos-chrome after commenting 'Get started'?
> Anyway, commit it, and I'll let you know if something breaks. I don't expect
it
> to.

Yes, I did emerge. Thanks, I'll commit now.