Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Unified Diff: chrome/browser/chromeos/login/issue_response_handler.cc

Issue 7121014: When a user logs into sync, the appropriate cookies are retrieved so that (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Fix unit test breaks on chromeos trybots Created 9 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/login/issue_response_handler.cc
===================================================================
--- chrome/browser/chromeos/login/issue_response_handler.cc (revision 89672)
+++ chrome/browser/chromeos/login/issue_response_handler.cc (working copy)
@@ -25,8 +25,7 @@
const std::string& to_process,
URLFetcher::Delegate* catcher) {
VLOG(1) << "Handling IssueAuthToken response";
- token_url_.assign(base::StringPrintf("%s%s",
- GaiaUrls::GetInstance()->token_auth_url().c_str(), to_process.c_str()));
+ token_url_.assign(BuildTokenAuthUrlWithToken(to_process));
URLFetcher* fetcher =
new URLFetcher(GURL(token_url_), URLFetcher::GET, catcher);
fetcher->set_load_flags(net::LOAD_DO_NOT_SEND_COOKIES);
@@ -38,4 +37,16 @@
return fetcher;
}
+// static
+std::string IssueResponseHandler::BuildTokenAuthUrlWithToken(
+ const std::string& token) {
+ const char kUrlFormat[] = "%s?"
+ "continue=http://www.google.com/webhp&"
+ "source=chromeos&"
+ "auth=%s";
+ return base::StringPrintf(kUrlFormat,
Chris Masone 2011/06/21 01:26:31 Why aren't you using GaiaAuthFetcher::MakeTokenAut
Roger Tawa OOO till Jul 10th 2011/06/21 03:21:13 All the GaiaAuthFetcher::MakeXxxBody() functions a
+ GaiaUrls::GetInstance()->token_auth_url().c_str(),
+ token.c_str());
+}
+
} // namespace chromeos

Powered by Google App Engine
This is Rietveld 408576698