Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(145)

Unified Diff: chrome/browser/chromeos/login/cookie_fetcher_unittest.cc

Issue 7121014: When a user logs into sync, the appropriate cookies are retrieved so that (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Fix unit test breaks on chromeos trybots Created 9 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/login/cookie_fetcher_unittest.cc
===================================================================
--- chrome/browser/chromeos/login/cookie_fetcher_unittest.cc (revision 89672)
+++ chrome/browser/chromeos/login/cookie_fetcher_unittest.cc (working copy)
@@ -182,11 +182,10 @@
TEST_F(CookieFetcherTest, IssueResponseHandlerTest) {
IssueResponseHandler handler(NULL);
- std::string input("a\n");
- std::string expected(GaiaUrls::GetInstance()->token_auth_url());
- expected.append(input);
+ std::string expected(IssueResponseHandler::BuildTokenAuthUrlWithToken(
+ std::string("a")));
- scoped_ptr<URLFetcher> fetcher(handler.Handle(input, NULL));
+ scoped_ptr<URLFetcher> fetcher(handler.Handle(std::string("a"), NULL));
Chris Masone 2011/06/21 01:26:31 so, the trailing newline is fatal? Why?
Roger Tawa OOO till Jul 10th 2011/06/21 03:21:13 My bad. I meant to put it back but forgot.
EXPECT_EQ(expected, handler.token_url());
}

Powered by Google App Engine
This is Rietveld 408576698