Issue 7113013: Added missing include to os2.cc to enable building with gcc-4.6.0

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7113013: Added missing include to os2.cc to enable building with gcc-4.6.0 (Closed)

Created:
9 years, 6 months ago by asharif1

Modified:
9 years, 6 months ago

Reviewers:
Yusuke Sato, bashi

CC:
chromium-reviews, bjanakiraman1

Base URL:
http://ots.googlecode.com/svn/trunk/

Visibility:
Public.

Description

Added missing include to os2.cc. os2.cc uses stddef.h's offsetof().

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Created: 9 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	M	src/ots.h	View	1 2 3	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

asharif1

Adding derat, since he may be available. Note: I'm not a chromium commiter.

9 years, 6 months ago (2011-06-06 21:32:23 UTC) #2

Daniel Erat

On 2011/06/06 21:32:23, asharif1 wrote: > Adding derat, since he may be available. Note: I'm ...

9 years, 6 months ago (2011-06-06 21:34:36 UTC) #3

Yusuke Sato

LGTM. I'll submit this on behalf of you shortly, and will update DEPS in Chrome. ...

9 years, 6 months ago (2011-06-06 22:23:35 UTC) #5

Yusuke Sato

9 years, 6 months ago (2011-06-07 05:27:12 UTC) #6

Landed.
http://code.google.com/p/ots/source/detail?r=69

Thanks for the patch!

On 2011/06/06 22:23:35, Yusuke Sato wrote:
> LGTM. I'll submit this on behalf of you shortly, and will update DEPS in
Chrome.
> 
> (bashi, I'll take care of this since this change is related to Chrome OS.)

Expand Messages | Collapse Messages