CrOS - Fix crash when pressing Enter in file browser dialog

chrome/browser/ui/views/file_manager_dialog.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/views/file_manager_dialog.h"
 
 #include "base/logging.h"
 #include "base/memory/ref_counted.h"
 #include "chrome/browser/extensions/extension_file_browser_private_api.h"
 #include "chrome/browser/extensions/file_manager_util.h"
 #include "chrome/browser/ui/browser.h"
 #include "chrome/browser/ui/browser_list.h"
+#include "chrome/browser/ui/browser_window.h"
 #include "chrome/browser/ui/views/extensions/extension_dialog.h"
 #include "chrome/browser/ui/views/window.h"
 #include "content/browser/browser_thread.h"
 #include "content/browser/tab_contents/tab_contents.h"
 #include "views/window/window.h"
 
 namespace {
 
 const int kFileManagerWidth = 720;  // pixels
 const int kFileManagerHeight = 580;  // pixels
 
+// Returns the browser represented by |window| or NULL if not found.

[achuithb, 2011/06/10 22:09:40]

Add a TODO to move this code to browser_list.h which is a better home for this.

+Browser* FindBrowserWithWindow(gfx::NativeWindow window) {
+  for (BrowserList::const_iterator it = BrowserList::begin();
+       it != BrowserList::end();
+       ++it) {
+    Browser* browser = *it;
+    if (browser->window() && browser->window()->GetNativeHandle() == window)
+      return browser;
+  }
+  return NULL;
 }
 
+}  // namespace
+
 // Linking this implementation of SelectFileDialog::Create into the target
 // selects FileManagerDialog as the dialog of choice.
 // static
 SelectFileDialog* SelectFileDialog::Create(Listener* listener) {
   DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
   return new FileManagerDialog(listener);
 }
 
 /////////////////////////////////////////////////////////////////////////////
 
@@ skipping 37 matching lines @@
     const FilePath& default_path,
     const FileTypeInfo* file_types,
     int file_type_index,
     const FilePath::StringType& default_extension,
     gfx::NativeWindow owner_window,
     void* params) {
   if (owner_window_) {
     LOG(ERROR) << "File dialog already in use!";
     return;
   }
-  Browser* active_browser = BrowserList::GetLastActive();
-  if (!active_browser)
+  Browser* owner_browser = FindBrowserWithWindow(owner_window);
+  if (!owner_browser) {

[achuithb, 2011/06/10 22:09:40]

A DCHECK is probably appropriate here.

+    LOG(WARNING) << "Can't find owning browser";
     return;
+  }
 
   GURL file_browser_url = FileManagerUtil::GetFileBrowserUrlWithParams(
       type, title, default_path, file_types, file_type_index,
       default_extension);
   extension_dialog_ = ExtensionDialog::Show(file_browser_url,
-      active_browser, kFileManagerWidth, kFileManagerHeight,
+      owner_browser, kFileManagerWidth, kFileManagerHeight,
       this /* ExtensionDialog::Observer */);
 
   // Connect our listener to FileDialogFunction's per-tab callbacks.
-  Browser* extension_browser = extension_dialog_->host()->view()->browser();
-  TabContents* contents = extension_browser->GetSelectedTabContents();
+  TabContents* contents = owner_browser->GetSelectedTabContents();
   int32 tab_id = (contents ? contents->controller().session_id().id() : 0);
   FileDialogFunction::Callback::Add(tab_id, listener_, params);
 
   tab_id_ = tab_id;
   owner_window_ = owner_window;
 }