Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(386)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 7108035: Revert 88400 (Probable breaker of XP Tests(dbg)(5), 10.6 Tests (dbg)(2), 10.5 Tests (dbg)(2)) (Closed)

Created:
9 years, 6 months ago by Ryan Sleevi
Modified:
9 years, 6 months ago
Reviewers:
Miranda Callahan
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 88400 (Probable breaker of XP Tests(dbg)(5), 10.6 Tests (dbg)(2), 10.5 Tests (dbg)(2)) 88400 - Use the System URL Request Context in the web resource service instead of the default profile's context. This change should be made because there will be no more default profile, because these services should be able to run without being attached to a specific profile, and because they should only ever fetch json data from controlled URLs. BUG=64339 TEST=all current web resource tests continue to work. Review URL: http://codereview.chromium.org/7099004 TBR=mirandac@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=88477

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -10 lines) Patch
M chrome/browser/web_resource/gpu_blacklist_updater.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/web_resource/promo_resource_service.h View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/web_resource/promo_resource_service.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/web_resource/web_resource_service.h View 4 chunks +6 lines, -4 lines 0 comments Download
M chrome/browser/web_resource/web_resource_service.cc View 5 chunks +7 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Ryan Sleevi
9 years, 6 months ago (2011-06-09 02:43:00 UTC) #1
Ryan Sleevi
10.5 Tests (dbg)(2) log: http://build.chromium.org/p/chromium/builders/Mac%2010.5%20Tests%20%28dbg%29%282%29/builds/9126 [ RUN ] ExtensionBrowserTest.UnloadPageAction /b/build/third_party/zope/__init__.py:19: UserWarning: Module zope was already ...
9 years, 6 months ago (2011-06-09 02:44:06 UTC) #2
Ryan Sleevi
XP Tests (dbg)(5) log http://build.chromium.org/p/chromium/builders/XP%20Tests%20%28dbg%29%285%29/builds/4606 [2176:2368:0608/185338:894562:WARNING:file_util_win.cc(774)] CreateFile failed for path C:\DOCUME~1\CHROME~2\LOCALS~1\Temp\scoped_dir22467\Default\History Provider Cache error code=32 ...
9 years, 6 months ago (2011-06-09 02:44:51 UTC) #3
Ryan Sleevi
10.6 Tests (dbg)(2) log (the one used to decide 88400 was to blame) http://build.chromium.org/p/chromium/builders/Mac%2010.6%20Tests%20%28dbg%29%282%29/builds/10305 [ ...
9 years, 6 months ago (2011-06-09 02:45:46 UTC) #4
Miranda Callahan
9 years, 6 months ago (2011-06-09 15:42:01 UTC) #5 
On 2011/06/09 02:45:46, Ryan Sleevi wrote:
> 10.6 Tests (dbg)(2) log (the one used to decide 88400 was to blame)
> 
>
http://build.chromium.org/p/chromium/builders/Mac%252010.6%2520Tests%2520%252...
> 
> 
> [ RUN      ] ExtensionCrashRecoveryTest.TwoExtensionsOneByOne
> [1090:263:0608/184419:738378388755:WARNING:pref_notifier_impl.cc(24)] pref
> observer found at shutdown plugins.always_authorize
> [1090:263:0608/184419:738378456050:WARNING:pref_notifier_impl.cc(24)] pref
> observer found at shutdown plugins.allow_outdated
> [1090:22531:0608/184419:738381923652:ERROR:leak_tracker.h(95)] Leaked
0x25f062d4
> which was allocated by:
> [1090:22531:0608/184419:738381969634:ERROR:leak_tracker.h(96)] Backtrace:
> 	0   browser_tests                       0x0003e942
> base::debug::StackTrace::StackTrace() + 32
> 	1   browser_tests                       0x00747ad6
> base::debug::LeakTracker<SystemURLRequestContextGetter>::LeakTracker() + 32
> 	2   browser_tests                       0x007455a9
> SystemURLRequestContextGetter::SystemURLRequestContextGetter(IOThread*) + 85
> 	3   browser_tests                       0x007456b9
> IOThread::system_url_request_context_getter() + 267
> 	4   browser_tests                       0x00469f99
> BrowserProcessImpl::system_request_context() + 203
> 	5   browser_tests                       0x00cc9831
> WebResourceService::WebResourceFetcher::StartFetch() + 527
> 	6   browser_tests                       0x00cc86a7 void
> DispatchToMethod<WebResourceService::WebResourceFetcher, void
>
(WebResourceService::WebResourceFetcher::*)()>(WebResourceService::WebResourceFetcher*,
> void (WebResourceService::WebResourceFetcher::*)(), Tuple0 const&) + 56
> 	7   browser_tests                       0x00cc9299
>
ScopedRunnableMethodFactory<WebResourceService::WebResourceFetcher>::RunnableMethod<void
> (WebResourceService::WebResourceFetcher::*)(), Tuple0>::Run() + 81
> 	8   browser_tests                       0x00e5b0d0 (anonymous
> namespace)::TaskClosureAdapter::Run() + 30
> 	9   browser_tests                       0x00e5b4c8
> base::internal::Invoker1<false, base::internal::InvokerStorage1<void
((anonymous
> namespace)::TaskClosureAdapter::*)(), (anonymous
> namespace)::TaskClosureAdapter*>, void ((anonymous
>
namespace)::TaskClosureAdapter::*)()>::DoInvoke(base::internal::InvokerStorageBase*)
> + 94
> 	10  browser_tests                       0x00e5ed5c base::Callback<void
> ()()>::Run() const + 34
> 	11  browser_tests                       0x00e5c2fa
> MessageLoop::RunTask(MessageLoop::PendingTask const&) + 326
> 	12  browser_tests                       0x00e5c41f
> MessageLoop::DeferOrRunPendingTask(MessageLoop::PendingTask const&) + 51
> 	13  browser_tests                       0x00e5c5e3
> MessageLoop::DoDelayedWork(base::TimeTicks*) + 409
> 	14  browser_tests                       0x00e1c6cb
> base::MessagePumpCFRunLoopBase::RunWork() + 129
> 	15  browser_tests                       0x00e1c7a2
> base::MessagePumpCFRunLoopBase::RunNestingDeferredWork() + 36
> 	16  browser_tests                       0x00e1c7f5
> base::MessagePumpCFRunLoopBase::RunNestingDeferredWorkSource(void*) + 23
> 	17  CoreFoundation                      0x932fb361 __CFRunLoopDoSources0 +
1201
> 	18  CoreFoundation                      0x932f8f8f __CFRunLoopRun + 1071
> 	19  CoreFoundation                      0x932f8464 CFRunLoopRunSpecific + 452
> 	20  CoreFoundation                      0x932f8291 CFRunLoopRunInMode + 97
> 	21  HIToolbox                           0x93ae5e04 RunCurrentEventLoopInMode
+
> 392
> 	22  HIToolbox                           0x93ae5bb9 ReceiveNextEventCommon +
354
> 	23  HIToolbox                           0x93ae5a3e
> BlockUntilNextEventMatchingListInMode + 81
> 	24  AppKit                              0x921d478d _DPSNextEvent + 847
> 	25  AppKit                              0x921d3fce -[NSApplication
> nextEventMatchingMask:untilDate:inMode:dequeue:] + 156
> 	26  AppKit                              0x92196247 -[NSApplication run] + 821
> 	27  browser_tests                       0x00e1c186
> base::MessagePumpNSApplication::DoRun(base::MessagePump::Delegate*) + 256
> 	28  browser_tests                       0x00e1c4c1
> base::MessagePumpCFRunLoopBase::Run(base::MessagePump::Delegate*) + 143
> 	29  browser_tests                       0x00e5d4d2 MessageLoop::RunInternal()
+
> 188
> 	30  browser_tests                       0x00e5d4ed MessageLoop::RunHandler()
+
> 17
> 	31  browser_tests                       0x00e5d551 MessageLoop::Run() + 35
> 	32  browser_tests                       0x00e018c4
> ui_test_utils::RunMessageLoop() + 58
> 	33  browser_tests                       0x00df3543
> InProcessBrowserTest::QuitBrowsers() + 125
> 	34  browser_tests                       0x00df3718
> InProcessBrowserTest::RunTestOnMainThreadLoop() + 462
> 	35  browser_tests                       0x00df4e33 void
> DispatchToMethod<InProcessBrowserTest, void
> (InProcessBrowserTest::*)()>(InProcessBrowserTest*, void
> (InProcessBrowserTest::*)(), Tuple0 const&) + 56
> 	36  browser_tests                       0x00df4e6f
> RunnableMethod<InProcessBrowserTest, void (InProcessBrowserTest::*)(),
> Tuple0>::Run() + 57
> 	37  browser_tests                       0x00462972
> BrowserMain(MainFunctionParams const&) + 6768
> 	38  browser_tests                       0x00df4378
> InProcessBrowserTest::SetUp() + 1298
> 	39  browser_tests                       0x011f2f31 void
> testing::internal::HandleSehExceptionsInMethodIfSupported<testing::Test,
> void>(testing::Test*, void (testing::Test::*)(), char const*) + 56
> 	40  browser_tests                       0x011f9168 void
> testing::internal::HandleExceptionsInMethodIfSupported<testing::Test,
> void>(testing::Test*, void (testing::Test::*)(), char const*) + 55
> 	41  browser_tests                       0x011ed541 testing::Test::Run() + 111
> 	42  browser_tests                       0x011f17c3 testing::TestInfo::Run() +
> 249
> 	43  browser_tests                       0x011f194c testing::TestCase::Run() +
> 230
> 	44  browser_tests                       0x011f25fc
> testing::internal::UnitTestImpl::RunAllTests() + 658
> 	45  browser_tests                       0x011f3093 bool
>
testing::internal::HandleSehExceptionsInMethodIfSupported<testing::internal::UnitTestImpl,
> bool>(testing::internal::UnitTestImpl*, bool
> (testing::internal::UnitTestImpl::*)(), char const*) + 56
> 	46  browser_tests                       0x011f9009 bool
>
testing::internal::HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl,
> bool>(testing::internal::UnitTestImpl*, bool
> (testing::internal::UnitTestImpl::*)(), char const*) + 55
> 	47  browser_tests                       0x011ea8cb testing::UnitTest::Run() +
> 111
> 	48  browser_tests                       0x00ec978c base::TestSuite::Run() +
216
> 	49  browser_tests                       0x002f2676 main + 1037
> 	50  browser_tests                       0x00096f7e start + 54
> 
> [1090:22531:0608/184419:738612815930:FATAL:leak_tracker.h(100)] Check failed:
0u
> == count (0 vs. 1)
> Backtrace:
> 	0   browser_tests                       0x0003e942
> base::debug::StackTrace::StackTrace() + 32
> 	1   browser_tests                       0x0003f2c2
> logging::LogMessage::~LogMessage() + 42
> 	2   browser_tests                       0x00748015
> base::debug::LeakTracker<SystemURLRequestContextGetter>::CheckForLeaks() + 578
> 	3   browser_tests                       0x00744041 IOThread::CleanUp() + 527
> 	4   browser_tests                       0x00ea651f base::Thread::ThreadMain()
+
> 361
> 	5   browser_tests                       0x00ea240b base::(anonymous
> namespace)::ThreadFunc(void*) + 75
> 	6   libSystem.B.dylib                   0x972fc7fd _pthread_start + 345
> 	7   libSystem.B.dylib                   0x972fc682 thread_start + 34
> 
> [1090:22531:0608/184419:738612815930:FATAL:leak_tracker.h(100)] Check failed:
0u
> == count (0 vs. 1)
> Backtrace:
> 	0   browser_tests                       0x0003e942
> base::debug::StackTrace::StackTrace() + 32
> 	1   browser_tests                       0x0003f2c2
> logging::LogMessage::~LogMessage() + 42
> 	2   browser_tests                       0x00748015
> base::debug::LeakTracker<SystemURLRequestContextGetter>::CheckForLeaks() + 578
> 	3   browser_tests                       0x00744041 IOThread::CleanUp() + 527
> 	4   browser_tests                       0x00ea651f base::Thread::ThreadMain()
+
> 361
> 	5   browser_tests                       0x00ea240b base::(anonymous
> namespace)::ThreadFunc(void*) + 75
> 	6   libSystem.B.dylib                   0x972fc7fd _pthread_start + 345
> 	7   libSystem.B.dylib                   0x972fc682 thread_start + 34

Thanks, LGTM.

Powered by Google App Engine
This is Rietveld 408576698