Use the System URL Request Context in the web resource service instead of the default profile's c...

Use the System URL Request Context in the web resource service instead of the default profile's context.

This change should be made because there will be no more default profile, because these services should be able to run without being attached to a specific profile, and because they should only ever fetch json data from controlled URLs.

BUG=64339
TEST=all current web resource tests continue to work.
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=88400

[Miranda Callahan, 2011-06-08 18:29:31]

willchan for proper system_url_context call, and jstritar to make sure I didn't
do anything foolish with the WRS -- thanks!

[willchan no longer on Chromium, 2011-06-08 19:13:27]

Code looks great. I just want to doublecheck exactly what WebResourceService
does before I OK the use of the system URLRequestContext for this. Can you
clarify exactly what content we fetch with this?

[Miranda Callahan, 2011-06-08 19:17:35]

On 2011/06/08 19:13:27, willchan wrote:
> Code looks great. I just want to doublecheck exactly what WebResourceService
> does before I OK the use of the system URLRequestContext for this. Can you
> clarify exactly what content we fetch with this?

Sure -- this is used to download JSON data from a server to use for dynamically
configuring things in the browser.  For example, it downloads from these sites
now:

promo resources: 
https://www.google.com/support/chrome/bin/topic/1142433/inproduct?hl=

gpu blacklist resources:
https://dl.google.com/dl/edgedl/chrome/gpu/software_rendering_list.json

[jstritar, 2011-06-08 19:18:31]

LGTM (as long as willchan is satisfied with the use of the system
URLRequestContext)

[willchan no longer on Chromium, 2011-06-08 19:38:10]

LGTM. Is it possible to add documentation that WebResourceService
should never load Profile-specific content? To me (I'm not familiar
with the code though) it looks non-obvious that all content must be
profile agnostic.

On Wed, Jun 8, 2011 at 10:17 PM,  <mirandac@chromium.org> wrote:
> On 2011/06/08 19:13:27, willchan wrote:
>>
>> Code looks great. I just want to doublecheck exactly what
>> WebResourceService
>> does before I OK the use of the system URLRequestContext for this. Can you
>> clarify exactly what content we fetch with this?
>
> Sure -- this is used to download JSON data from a server to use for
> dynamically
> configuring things in the browser.  For example, it downloads from these
> sites
> now:
>
> promo resources:
> https://www.google.com/support/chrome/bin/topic/1142433/inproduct?hl=
>
> gpu blacklist resources:
> https://dl.google.com/dl/edgedl/chrome/gpu/software_rendering_list.json
>
> http://codereview.chromium.org/7099004/
>

[Miranda Callahan, 2011-06-08 21:06:42]

On 2011/06/08 19:38:10, willchan wrote:
> LGTM. Is it possible to add documentation that WebResourceService
> should never load Profile-specific content? To me (I'm not familiar
> with the code though) it looks non-obvious that all content must be
> profile agnostic.
> 
> On Wed, Jun 8, 2011 at 10:17 PM,  <mailto:mirandac@chromium.org> wrote:
> > On 2011/06/08 19:13:27, willchan wrote:
> >>
> >> Code looks great. I just want to doublecheck exactly what
> >> WebResourceService
> >> does before I OK the use of the system URLRequestContext for this. Can you
> >> clarify exactly what content we fetch with this?
> >
> > Sure -- this is used to download JSON data from a server to use for
> > dynamically
> > configuring things in the browser. &nbsp;For example, it downloads from
these
> > sites
> > now:
> >
> > promo resources:
> > https://www.google.com/support/chrome/bin/topic/1142433/inproduct?hl=
> >
> > gpu blacklist resources:
> > https://dl.google.com/dl/edgedl/chrome/gpu/software_rendering_list.json
> >
> > http://codereview.chromium.org/7099004/
> >

Added an explanatory comment pointing back to this code review. Thanks!