chrome/common/chrome_version_info.h - Issue 7104106: Unify the version string to be displayed on "About Chromium" dialog.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/chrome_version_info.h

Issue 7104106: Unify the version string to be displayed on "About Chromium" dialog. (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk

Patch Set: Skip CreateVersionString() for NACL_WIN64 Created 9 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/cocoa/about_window_controller.mm ('K') | « chrome/browser/ui/gtk/about_chrome_dialog.cc ('k') | chrome/common/chrome_version_info.cc » ('j') | chrome/common/chrome_version_info.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/chrome_version_info.h

diff --git a/chrome/common/chrome_version_info.h b/chrome/common/chrome_version_info.h

index 21ad32fe7dbe2c2a0935f04a3aab2f82d54bf278..84292e5e1014962da8f82d0052f32813e2a28262 100644

--- a/chrome/common/chrome_version_info.h

+++ b/chrome/common/chrome_version_info.h

@@ -72,6 +72,9 @@ class VersionInfo {

// will be CHANNEL_UNKNOWN.

static Channel GetChannel();

+ // Returns a version string to be displayed in "About Chromium" dialog.

+ std::string CreateVersionString() const;

private:

#if defined(OS_WIN) || defined(OS_MACOSX)

scoped_ptr<FileVersionInfo> version_info_;