Unify the version string to be displayed on "About Chromium" dialog.

chrome/browser/ui/cocoa/about_window_controller.mm

Index: chrome/browser/ui/cocoa/about_window_controller.mm
diff --git a/chrome/browser/ui/cocoa/about_window_controller.mm b/chrome/browser/ui/cocoa/about_window_controller.mm
index e0efd1924e5d0166ef1065d940f84fdcd74aaa89..89d255049c9df547e80f49a0b92959a90cbd3110 100644
--- a/chrome/browser/ui/cocoa/about_window_controller.mm
+++ b/chrome/browser/ui/cocoa/about_window_controller.mm
@@ -130,26 +130,12 @@ void AttributedStringAppendHyperlink(NSMutableAttributedString* attr_str,
 static BOOL recentShownUserActionFailedStatus = NO;
 
 - (void)awakeFromNib {
-  NSBundle* bundle = base::mac::MainAppBundle();
-  NSString* chromeVersion =
-      [bundle objectForInfoDictionaryKey:@"CFBundleShortVersionString"];
-
-  NSString* versionModifier = @"";
-  NSString* svnRevision = @"";
-  std::string modifier = chrome::VersionInfo::GetVersionStringModifier();
-  if (!modifier.empty())
-    versionModifier = [NSString stringWithFormat:@" %@",
-                                base::SysUTF8ToNSString(modifier)];
-
-#if !defined(GOOGLE_CHROME_BUILD)
-  svnRevision = [NSString stringWithFormat:@" (%@)",
-                          [bundle objectForInfoDictionaryKey:@"SVNRevision"]];
-#endif
+  chrome::VersionInfo version_info;

[Mark Mentovai, 2011/06/30 13:34:23]

Put this below the comment, not above it.

[haraken1, 2011/07/04 07:50:52]

Done.

   // The format string is not localized, but this is how the displayed version
   // is built on Windows too.
-  NSString* version =
-    [NSString stringWithFormat:@"%@%@%@",
-              chromeVersion, svnRevision, versionModifier];
+  NSString* version = [NSString stringWithFormat:@"%@",

[Mark Mentovai, 2011/06/30 13:34:23]

This is like saying

  snprintf(buf, arraysize(buf), "%s", FunctionThatReturnsCharPointer());

What you should have written:

  NSString* version =
base::SysUTF8ToNSString(version_info.CreateVersionString());

[haraken1, 2011/07/04 07:50:52]

Done.

+                                base::SysUTF8ToNSString(
+                                    version_info.CreateVersionString())];
 
   [version_ setStringValue:version];