Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Unified Diff: chrome/browser/ui/views/about_chrome_view.h

Issue 7104106: Unify the version string to be displayed on "About Chromium" dialog. (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk
Patch Set: Unify the version string to be displayed on "About Chromium" dialog Created 9 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/about_chrome_view.h
diff --git a/chrome/browser/ui/views/about_chrome_view.h b/chrome/browser/ui/views/about_chrome_view.h
index 35c02ec60ef439917ad5493809340c57a5406bca..7a4426a6ea7c328547dc0eb4afc8ebbc0a7c7d05 100644
--- a/chrome/browser/ui/views/about_chrome_view.h
+++ b/chrome/browser/ui/views/about_chrome_view.h
@@ -95,7 +95,6 @@ class AboutChromeView : public views::View,
views::ImageView* about_dlg_background_logo_;
views::Label* about_title_label_;
views::Textfield* version_label_;
- views::Textfield* os_version_label_;
tony 2011/06/14 18:56:31 I suspect this is here for a reason and we shouldn
haraken1 2011/06/15 04:20:41 I think it is OK to remove |os_version_label_| sin
views::Label* copyright_label_;
views::Label* main_text_label_;
int main_text_label_height_;
@@ -135,12 +134,6 @@ class AboutChromeView : public views::View,
scoped_refptr<GoogleUpdate> google_updater_;
#endif
- // Our current version.
- std::string current_version_;
-
- // Additional information about the version (channel and build number).
- std::string version_details_;
-
// The version Google Update reports is available to us.
std::wstring new_version_available_;

Powered by Google App Engine
This is Rietveld 408576698